Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29550794: Noissue - Removed DD_belatedPNG because we don't support IE 6 (Closed)

Created:
Sept. 20, 2017, 4:27 p.m. by juliandoucette
Modified:
Sept. 22, 2017, 6:14 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Note: This is a low priority issue. We don't test or support IE 6. So there is no need to keep this.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed DD_belatedPNG.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
R static/js/vendor/DD_belatedPNG.js View 1 1 chunk +0 lines, -13 lines 0 comments Download
M templates/default.tmpl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6
juliandoucette
Sept. 20, 2017, 4:27 p.m. (2017-09-20 16:27:44 UTC) #1
ire
https://codereview.adblockplus.org/29550794/diff/29550795/templates/default.tmpl File templates/default.tmpl (left): https://codereview.adblockplus.org/29550794/diff/29550795/templates/default.tmpl#oldcode63 templates/default.tmpl:63: <script>DD_belatedPNG.fix(".sprite");</script> The actual DD_belatedPNG.js is still in the repo
Sept. 21, 2017, 8:18 a.m. (2017-09-21 08:18:38 UTC) #2
juliandoucette
On 2017/09/21 08:18:38, ire wrote: > https://codereview.adblockplus.org/29550794/diff/29550795/templates/default.tmpl > File templates/default.tmpl (left): > > https://codereview.adblockplus.org/29550794/diff/29550795/templates/default.tmpl#oldcode63 > ...
Sept. 21, 2017, 2:42 p.m. (2017-09-21 14:42:12 UTC) #3
juliandoucette
https://codereview.adblockplus.org/29550794/diff/29550795/templates/default.tmpl File templates/default.tmpl (left): https://codereview.adblockplus.org/29550794/diff/29550795/templates/default.tmpl#oldcode63 templates/default.tmpl:63: <script>DD_belatedPNG.fix(".sprite");</script> On 2017/09/21 08:18:38, ire wrote: > The actual ...
Sept. 21, 2017, 2:44 p.m. (2017-09-21 14:44:17 UTC) #4
ire
LGTM
Sept. 21, 2017, 4:22 p.m. (2017-09-21 16:22:59 UTC) #5
juliandoucette
Sept. 22, 2017, 6:14 p.m. (2017-09-22 18:14:07 UTC) #6

Powered by Google App Engine
This is Rietveld