Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29551635: Issue 5735 - Use JS Map instead of Object for filters which are stored in filtersByDomain in elem... (Closed)

Created:
Sept. 21, 2017, 11:44 a.m. by sergei
Modified:
Sept. 26, 2017, 1:58 p.m.
Reviewers:
wspee, kzar, hub, Wladimir Palant
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/adblockpluscore.git
Visibility:
Public.

Description

# Rietveld has a restriction on the length of the title Issue 5735 - Use JS Map instead of Object for filters which are stored in filtersByDomain in elemHide.js # depends on https://codereview.adblockplus.org/29551632/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M lib/elemHide.js View 4 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 3
sergei
Sept. 21, 2017, noon (2017-09-21 12:00:58 UTC) #1
kzar
LGTM These changes got me thinking, I wonder if we could switch to WeakMap for ...
Sept. 22, 2017, 11:02 a.m. (2017-09-22 11:02:11 UTC) #2
Wladimir Palant
Sept. 25, 2017, 11:01 a.m. (2017-09-25 11:01:25 UTC) #3
LGTM

There is no point using WeakMap, since we never release Filter objects.

Powered by Google App Engine
This is Rietveld