Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29552627: Issue 4105 - [build] Make it possible to build arbitrary ABB revisions (Closed)

Created:
Sept. 22, 2017, 11:55 a.m. by René Jeschke
Modified:
Dec. 1, 2017, 3:55 p.m.
Visibility:
Public.

Description

Issue 4105 - [build] Make it possible to build arbitrary ABB revisions

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -0 lines) Patch
M .hgignore View 1 chunk +6 lines, -0 lines 0 comments Download
A abb-build/README.md View 1 chunk +29 lines, -0 lines 0 comments Download
A abb-build/adblockbrowser-cfg.py View 1 chunk +48 lines, -0 lines 1 comment Download
A abb-build/build.py View 1 chunk +172 lines, -0 lines 1 comment Download
A abb-build/config.py.sample View 1 chunk +7 lines, -0 lines 0 comments Download
A abb-build/dependencies View 1 chunk +3 lines, -0 lines 3 comments Download
A abb-build/ensure_dependencies.py View 1 chunk +380 lines, -0 lines 0 comments Download
A abb-build/mozconfig-arm View 1 chunk +2 lines, -0 lines 0 comments Download
A abb-build/mozconfig-common View 1 chunk +12 lines, -0 lines 0 comments Download
A abb-build/mozconfig-custom View 1 chunk +1 line, -0 lines 0 comments Download
A abb-build/mozconfig-release View 1 chunk +2 lines, -0 lines 0 comments Download
A abb-build/mozconfig-store View 1 chunk +2 lines, -0 lines 0 comments Download
A abb-build/mozconfig-x86 View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
René Jeschke
https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/adblockbrowser-cfg.py File abb-build/adblockbrowser-cfg.py (right): https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/adblockbrowser-cfg.py#newcode3 abb-build/adblockbrowser-cfg.py:3: BUILD_DIR = os.path.abspath("..") This had to be changed. https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/build.py ...
Sept. 22, 2017, 11:57 a.m. (2017-09-22 11:57:41 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies File abb-build/dependencies (right): https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies#newcode2 abb-build/dependencies:2: _self = ensure_dependencies.py On 2017/09/22 11:57:40, René Jeschke wrote: ...
Sept. 22, 2017, 5:58 p.m. (2017-09-22 17:58:36 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies File abb-build/dependencies (right): https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies#newcode2 abb-build/dependencies:2: _self = ensure_dependencies.py On 2017/09/22 17:58:36, diegocarloslima wrote: > ...
Oct. 5, 2017, 4:10 p.m. (2017-10-05 16:10:44 UTC) #3
René Jeschke
On 2017/10/05 16:10:44, diegocarloslima wrote: > https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies > File abb-build/dependencies (right): > > https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies#newcode2 > ...
Nov. 13, 2017, 3:16 p.m. (2017-11-13 15:16:30 UTC) #4
diegocarloslima
On 2017/11/13 15:16:30, René Jeschke wrote: > On 2017/10/05 16:10:44, diegocarloslima wrote: > > > ...
Nov. 24, 2017, 9:36 p.m. (2017-11-24 21:36:28 UTC) #5
René Jeschke
Nov. 28, 2017, 10:35 a.m. (2017-11-28 10:35:11 UTC) #6 
On 2017/11/24 21:36:28, diegocarloslima wrote:
> On 2017/11/13 15:16:30, René Jeschke wrote:
> > On 2017/10/05 16:10:44, diegocarloslima wrote:
> > >
> >
>
https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependencies
> > > File abb-build/dependencies (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29552627/diff/29552628/abb-build/dependenc...
> > > abb-build/dependencies:2: _self = ensure_dependencies.py
> > > On 2017/09/22 17:58:36, diegocarloslima wrote:
> > > > On 2017/09/22 11:57:40, René Jeschke wrote:
> > > > > I'm not sure where I should point _self to, maybe someone might give
me
> a
> > > hint
> > > > > here.
> > > > 
> > > > Maybe `../adblockbrowser/buildtools/ensure_dependencies.py`
> > > 
> > > I believe it would be better, because it would keep the
ensure_dependencies
> in
> > > the abb-build folder consistent with the one in adblockbrowser folder.
What
> do
> > > you think?
> > 
> > I talked to Felix about this issue and we decided to leave it 'as-is' for
now,
> > as
> > 'ensure_dependencies.py' does not throw any error and the given '_self' is
the
> > correct location for the used 'ensure_dependencies.py'.
> 
> LGTM, just need to reflect the changes introduced in
> 
> https://hg.adblockplus.org/adblockbrowser-build/rev/beb998b2b593
> https://hg.adblockplus.org/adblockbrowser-build/rev/569a3959f472
> https://hg.adblockplus.org/adblockbrowser-build/rev/6ab20dc6e8a3
> https://hg.adblockplus.org/adblockbrowser-build/rev/50858bc06fd2
> 
> and also, update the mozharness dependency to 2987360d15cd

Will do, thanks. :-)

Powered by Google App Engine
This is Rietveld