Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29554579: Noissue - remove old options page sprite (Closed)

Created:
Sept. 24, 2017, 7:20 p.m. by saroyanm
Modified:
Sept. 26, 2017, 7:07 a.m.
Reviewers:
ire
Visibility:
Public.

Description

We were using options-sprite.png only for one checkbox icon which is waiting for actual SVG version, I think anyway it make sense to separate that icon to avoid having sprites.png where only small part is being used.

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
A skin/icons/checkbox.png View Binary file 0 comments Download
M skin/new-options.css View 4 chunks +12 lines, -14 lines 0 comments Download
R skin/options-sprite.png View Binary file 0 comments Download

Messages

Total messages: 2
saroyanm
Ire can you please have a look on this review when you will have time. ...
Sept. 24, 2017, 7:34 p.m. (2017-09-24 19:34:39 UTC) #1
ire
Sept. 25, 2017, 7:54 a.m. (2017-09-25 07:54:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld