#3927 - Clear Nginx cache when notifications are updated

#3927 - Clear Nginx cache when notifications are updated

[f.nicolaisen, 2017-09-28 11:05:25]

https://codereview.adblockplus.org/29557718/diff/29557719/modules/notificatio...
File modules/notificationserver/manifests/init.pp (right):

https://codereview.adblockplus.org/29557718/diff/29557719/modules/notificatio...
modules/notificationserver/manifests/init.pp:24: content => "nginx
ALL=(www-data) NOPASSWD:/usr/bin/$clear_cache\n",
Consider extracting 'www-data' here and below to make it obvious that they are
coupled.

https://codereview.adblockplus.org/29557718/diff/29557719/modules/notificatio...
modules/notificationserver/manifests/init.pp:34: incl =>
'/opt/notifications/.hg/hgrc',
No dependency on the notifications repo having been cloned already.

[mathias, 2017-09-28 12:00:00]

https://codereview.adblockplus.org/29557718/diff/29557719/modules/notificatio...
File modules/notificationserver/manifests/init.pp (right):

https://codereview.adblockplus.org/29557718/diff/29557719/modules/notificatio...
modules/notificationserver/manifests/init.pp:24: content => "nginx
ALL=(www-data) NOPASSWD:/usr/bin/$clear_cache\n",
On 2017/09/28 11:05:25, f.nicolaisen wrote:
> Consider extracting 'www-data' here and below to make it obvious that they are
> coupled.

Acknowledged.

https://codereview.adblockplus.org/29557718/diff/29557719/modules/notificatio...
modules/notificationserver/manifests/init.pp:34: incl =>
'/opt/notifications/.hg/hgrc',
On 2017/09/28 11:05:25, f.nicolaisen wrote:
> No dependency on the notifications repo having been cloned already.

Acknowledged.

Interestingly we just recently learned that the behavior of Puppet changed here
somewhere in the late 3.x versions:

"The order of resources in a Puppet manifest does not matter. Puppet assumes
that most resources are not related to each other and will manage the resources
in whatever order is most efficient." (2.x)

vs.

"By default, Puppet applies resources in the order they’re declared in their
manifest. However, if a group of resources must always be managed in a specific
order, you should explicitly declare such relationships with relationship
metaparameters, chaining arrows, and the require function." (4.x)

Nonetheless I prefer explicit notation of relationships anyway.

[f.nicolaisen, 2017-09-28 12:17:15]

LGTM