Issue 5752 - Removing safari support

Issue 5752 - Removing safari support

[tlucas, 2017-10-02 10:39:03]

Patch Set 1

* Removing safari build- and release targets

Please note that this was implemented on top of
https://issues.adblockplus.org/ticket/5751

[tlucas, 2017-10-02 10:43:36]

Adding Wladimir to CC.

[Sebastian Noack, 2017-10-03 02:31:03]

There are more files specific to Safari that can be removed:

xarfile.py
templates/Info.plist
templates/xartoc.xml.tmpl
templates/background.html.tmpl

[tlucas, 2017-10-04 12:04:11]

Patch Set 2

 * Rebasing agains 5751
 * Removing additional files

Please note, this code is rebase against

https://codereview.adblockplus.org/29562599/ @ Patch Set 2

https://codereview.adblockplus.org/29562614/diff/29564606/build.py
File build.py (right):

https://codereview.adblockplus.org/29562614/diff/29564606/build.py#newcode1
build.py:1: # This Source Code Form is subject to the terms of the Mozilla
Public
Note: All changes are the result of rebasing

https://codereview.adblockplus.org/29562614/diff/29564606/releaseAutomation.py
File releaseAutomation.py (right):

https://codereview.adblockplus.org/29562614/diff/29564606/releaseAutomation.p...
releaseAutomation.py:15: 
Note: Result of rebasing

[Vasily Kuznetsov, 2017-10-05 20:45:18]

Hi Tristan,

In general it all looks good to me, I just have one comment to the code changes
(see below).

I wasn't able to get the right sequence of prerequisite patches to make this one
apply clean, so I haven't run the tests but I trust that you have.

Cheers,
Vasily

https://codereview.adblockplus.org/29562614/diff/29564606/build.py
File build.py (right):

https://codereview.adblockplus.org/29562614/diff/29564606/build.py#newcode390
build.py:390: command.addOption('File containing private key and certificates
required to sign the package', short='k', long='key', value='file',
types=('chrome'))
Here `types` was a tuple and now became a string. If this is intended, you don't
need the parentheses, otherwise you need a comma before the closing parentheses.

[tlucas, 2017-10-06 09:21:55]

Patch Set 4

 * Fixed string / tuple mix-up

@ Vasily: the sequence of patches would be:

1. https://codereview.adblockplus.org/29561557/ @ PS 7
2. https://codereview.adblockplus.org/29562599/ @ PS 5
3. this one

https://codereview.adblockplus.org/29562614/diff/29564606/build.py
File build.py (right):

https://codereview.adblockplus.org/29562614/diff/29564606/build.py#newcode390
build.py:390: command.addOption('File containing private key and certificates
required to sign the package', short='k', long='key', value='file',
types=('chrome'))
On 2017/10/05 20:45:18, Vasily Kuznetsov wrote:
> Here `types` was a tuple and now became a string. If this is intended, you
don't
> need the parentheses, otherwise you need a comma before the closing
parentheses.

Done.

[Vasily Kuznetsov, 2017-10-09 20:18:42]

On 2017/10/06 09:21:55, tlucas wrote:
> Patch Set 4
> 
>  * Fixed string / tuple mix-up
> 
> @ Vasily: the sequence of patches would be:
> 
> 1. https://codereview.adblockplus.org/29561557/ @ PS 7
> 2. https://codereview.adblockplus.org/29562599/ @ PS 5
> 3. this one

I'm feeling somewhat lazy today and have a lot of reviews waiting for me so I'll
assume that if you are diligent enough to remember the sequence patch sets, you
have also remembered to run the tests and they have passed :). LGTM.

[Sebastian Noack, 2017-10-10 04:55:23]

LGTM

https://codereview.adblockplus.org/29562614/diff/29571611/build.py
File build.py (right):

https://codereview.adblockplus.org/29562614/diff/29571611/build.py#newcode14
build.py:14: knownTypes = ('gecko-webext', 'chrome', 'generic', 'edge')
These tuples should be rather set literals. Anyway, this is unrelated. But if
you agree, feel free to submit a separate "Noissue" patch.

[tlucas, 2017-10-10 13:01:02]

On 2017/10/10 04:55:23, Sebastian Noack wrote:
> LGTM
> 
> https://codereview.adblockplus.org/29562614/diff/29571611/build.py
> File build.py (right):
> 
> https://codereview.adblockplus.org/29562614/diff/29571611/build.py#newcode14
> build.py:14: knownTypes = ('gecko-webext', 'chrome', 'generic', 'edge')
> These tuples should be rather set literals. Anyway, this is unrelated. But if
> you agree, feel free to submit a separate "Noissue" patch.

Yes, i agree. Filed a new review: https://codereview.adblockplus.org/29572671/