Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29576570: Noissue - Added .clearfix to new apb.org .content (Closed)

Created:
Oct. 14, 2017, 1:37 p.m. by juliandoucette
Modified:
Oct. 16, 2017, 12:41 p.m.
Reviewers:
ire
Base URL:
https://bitbucket.org/adblockplus/adblockplus.org
Visibility:
Public.

Description

Noissue - Added .clearfix to new apb.org .content

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M static/css/main.css View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4
juliandoucette
Oct. 14, 2017, 1:37 p.m. (2017-10-14 13:37:11 UTC) #1
juliandoucette
Ack -> We should proboably add clearfix to website-defaults and website-defaults .content... If you agree ...
Oct. 14, 2017, 1:39 p.m. (2017-10-14 13:39:06 UTC) #2
ire
On 2017/10/14 13:39:06, juliandoucette wrote: > Ack -> We should proboably add clearfix to website-defaults ...
Oct. 16, 2017, 8:03 a.m. (2017-10-16 08:03:46 UTC) #3
ire
Oct. 16, 2017, 8:03 a.m. (2017-10-16 08:03:46 UTC) #4
On 2017/10/14 13:39:06, juliandoucette wrote:
> Ack -> We should proboably add clearfix to website-defaults and
website-defaults
> .content... If you agree then you can "Not LGTM" this review and I'll do it
> separately.
> 
> This makes a difference on pages like http://localhost:5000/en/deregifier
where
> the floating button or componont at the end of the page leaks into the footer
> margin.

Not LGTM

Powered by Google App Engine
This is Rietveld