Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29576576: Noissue - Added .clearfix to default-base and default-content (Closed)

Created:
Oct. 14, 2017, 1:43 p.m. by juliandoucette
Modified:
Oct. 17, 2017, 1:21 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Noissue - Added .clearfix to default-base and default-content

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M static/scss/_base.scss View 1 chunk +12 lines, -0 lines 2 comments Download
M static/scss/_content.scss View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
juliandoucette
Oct. 14, 2017, 1:43 p.m. (2017-10-14 13:43:41 UTC) #1
ire
LGTM. One NIT https://codereview.adblockplus.org/29576576/diff/29576588/static/scss/_base.scss File static/scss/_base.scss (right): https://codereview.adblockplus.org/29576576/diff/29576588/static/scss/_base.scss#newcode74 static/scss/_base.scss:74: .clearfix:after, NIT: I think these should ...
Oct. 16, 2017, 8:03 a.m. (2017-10-16 08:03:36 UTC) #2
juliandoucette
Oct. 17, 2017, 1:21 p.m. (2017-10-17 13:21:38 UTC) #3
https://hg.adblockplus.org/website-defaults/rev/92b0ef9e0654

https://codereview.adblockplus.org/29576576/diff/29576588/static/scss/_base.scss
File static/scss/_base.scss (right):

https://codereview.adblockplus.org/29576576/diff/29576588/static/scss/_base.s...
static/scss/_base.scss:74: .clearfix:after,
On 2017/10/16 08:03:36, ire wrote:
> NIT: I think these should be in a _utilities.scss file

Acknowledged.

I will address this separately.

Powered by Google App Engine
This is Rietveld