Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29587655: Noissue - Added device widths & refactored website-default utilities (Closed)

Created:
Oct. 24, 2017, 2:07 p.m. by juliandoucette
Modified:
Oct. 25, 2017, 11:23 a.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Noissue - Added device widths & refactored website-default utilities

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M static/scss/_base.scss View 1 chunk +0 lines, -13 lines 0 comments Download
M static/scss/_utilities.scss View 1 chunk +27 lines, -3 lines 2 comments Download

Messages

Total messages: 4
juliandoucette
Oct. 24, 2017, 2:07 p.m. (2017-10-24 14:07:19 UTC) #1
juliandoucette
Added note. https://codereview.adblockplus.org/29587655/diff/29587656/static/scss/_utilities.scss File static/scss/_utilities.scss (left): https://codereview.adblockplus.org/29587655/diff/29587656/static/scss/_utilities.scss#oldcode28 static/scss/_utilities.scss:28: margin: $small-space 0px; Because width says nothing ...
Oct. 24, 2017, 2:08 p.m. (2017-10-24 14:08:34 UTC) #2
ire
LGTM https://codereview.adblockplus.org/29587655/diff/29587656/static/scss/_utilities.scss File static/scss/_utilities.scss (left): https://codereview.adblockplus.org/29587655/diff/29587656/static/scss/_utilities.scss#oldcode28 static/scss/_utilities.scss:28: margin: $small-space 0px; On 2017/10/24 14:08:34, juliandoucette wrote: ...
Oct. 25, 2017, 9:20 a.m. (2017-10-25 09:20:01 UTC) #3
juliandoucette
Oct. 25, 2017, 11:22 a.m. (2017-10-25 11:22:55 UTC) #4

Powered by Google App Engine
This is Rietveld