Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/article.tmpl

Issue 29589595: Noissue - Use new utilities and .container from website-defaults (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Oct. 26, 2017, 10:44 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« static/scss/base/_variables.scss ('K') | « static/scss/layout/_navbar.scss ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/article.tmpl
===================================================================
--- a/templates/article.tmpl
+++ b/templates/article.tmpl
@@ -1,15 +1,15 @@
{% extends "templates/minimal" %}
{% set product = products[product_id] %}
{% block body %}
<nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" class="breadcrumb">
- <ol class="container clearfix" itemscope itemtype="http://schema.org/BreadcrumbList">
+ <ol class="container large-desktop-width clearfix" itemscope itemtype="http://schema.org/BreadcrumbList">
ire 2017/10/26 10:46:27 I thought it looked better if the breadcrumb was a
<li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem">
<a itemscope itemtype="http://schema.org/Thing" itemprop="item" href="{{ product.slug }}">
<img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcset="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | translate(product_id+"-logo-alt", "Image alt text") }}">
<span itemprop="name">{{ product.full_name | translate(product_id+"-name", "Product name") }}</span>
</a>
<meta itemprop="position" content="1" />
</li>
<li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem">
« static/scss/base/_variables.scss ('K') | « static/scss/layout/_navbar.scss ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld