Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29589595: Noissue - Use new utilities and .container from website-defaults (Closed)

Created:
Oct. 26, 2017, 10:44 a.m. by ire
Modified:
Oct. 27, 2017, 8:46 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Noissue - Use new utilities and .container from website-defaults

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M includes/layout/header.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M static/scss/base/_utilities.scss View 1 chunk +0 lines, -9 lines 1 comment Download
M static/scss/base/_variables.scss View 1 chunk +1 line, -6 lines 1 comment Download
M static/scss/layout/_navbar.scss View 1 chunk +0 lines, -10 lines 0 comments Download
M templates/article.tmpl View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5
ire
Oct. 26, 2017, 10:44 a.m. (2017-10-26 10:44:31 UTC) #1
ire
Ready https://codereview.adblockplus.org/29589595/diff/29589596/static/scss/base/_utilities.scss File static/scss/base/_utilities.scss (left): https://codereview.adblockplus.org/29589595/diff/29589596/static/scss/base/_utilities.scss#oldcode37 static/scss/base/_utilities.scss:37: // Clearfix /////////////////////////////////////////////////////////////// This is already in website-defaults ...
Oct. 26, 2017, 10:46 a.m. (2017-10-26 10:46:27 UTC) #2
juliandoucette
LGTM - Thank you for the comments.
Oct. 26, 2017, 11:16 a.m. (2017-10-26 11:16:41 UTC) #3
ire
On 2017/10/26 11:16:41, juliandoucette wrote: > LGTM - Thank you for the comments. You're welcome ...
Oct. 27, 2017, 8:45 a.m. (2017-10-27 08:45:41 UTC) #4
ire
Oct. 27, 2017, 8:46 a.m. (2017-10-27 08:46:04 UTC) #5

Powered by Google App Engine
This is Rietveld