Issue 29590597: Issue 5950 - Add privacy friendly acceptable ads documentation link redirect (Closed)
DescriptionIssue 5950 - Add privacy friendly acceptable ads documentation link redirect
Patch Set 1 #Patch Set 2 : Updated commit message #
MessagesTotal messages: 9
On 2017/10/27 12:42:53, wspee wrote: I think we need to backout changes in the -> https://issues.adblockplus.org/ticket/5869 as well.
@Winsley: Matze asked me to review this. Can you set me as reviewer? Note: Our commit messages usually use the present tense: "Add privacy friendly..". Also please refer to the change as a redirect rather than a link. On 2017/10/27 12:46:47, saroyanm wrote: > On 2017/10/27 12:42:53, wspee wrote: > > I think we need to backout changes in the -> > https://issues.adblockplus.org/ticket/5869 as well. Unless the link is published anywhere, it won't do any harm. If you want us to change or remove it, please request so in a ticket.
On 2017/10/27 13:23:54, f.nicolaisen wrote: > @Winsley: > Unless the link is published anywhere, it won't do any harm. If you want us to > change or remove it, please request so in a ticket. It used to be in the ticket :) Mind @wspee if I add it back to the description ? I think it's important to remove the unused re-directions.
On 2017/10/27 13:23:54, f.nicolaisen wrote: > @Winsley: > > Matze asked me to review this. Can you set me as reviewer? Done (You did this by replying, I removed Matze) > > Note: Our commit messages usually use the present tense: "Add privacy > friendly..". Done > Also please refer to the change as a redirect rather than a link. It's part of the name of the feature, I added redirect to the end. https://bitbucket.org/adblockplus/spec/src/eb15e756abbf94dc26c355f6534b387f80... > > On 2017/10/27 12:46:47, saroyanm wrote: > > On 2017/10/27 12:42:53, wspee wrote: > > > > I think we need to backout changes in the -> > > https://issues.adblockplus.org/ticket/5869 as well. > > Unless the link is published anywhere, it won't do any harm. If you want us to > change or remove it, please request so in a ticket.
On 2017/10/27 15:00:21, wspee wrote: > On 2017/10/27 13:23:54, f.nicolaisen wrote: > > @Winsley: > > > > Matze asked me to review this. Can you set me as reviewer? > Done (You did this by replying, I removed Matze) > > > > > Note: Our commit messages usually use the present tense: "Add privacy > > friendly..". > Done > Can you update the title/description of this review? That's where I (can) see and review the commit message.
On 2017/10/27 15:19:34, f.nicolaisen wrote: > On 2017/10/27 15:00:21, wspee wrote: > > On 2017/10/27 13:23:54, f.nicolaisen wrote: > > > @Winsley: > > > > > > Matze asked me to review this. Can you set me as reviewer? > > Done (You did this by replying, I removed Matze) > > > > > > > > Note: Our commit messages usually use the present tense: "Add privacy > > > friendly..". > > Done > > > > > Can you update the title/description of this review? That's where I (can) see > and review the commit message. Of course, sorry :).
On 2017/10/27 13:23:54, f.nicolaisen wrote: > @Winsley: > > Matze asked me to review this. Can you set me as reviewer? > > Note: Our commit messages usually use the present tense: "Add privacy > friendly..". > > Also please refer to the change as a redirect rather than a link. > > On 2017/10/27 12:46:47, saroyanm wrote: > > On 2017/10/27 12:42:53, wspee wrote: > > > > I think we need to backout changes in the -> > > https://issues.adblockplus.org/ticket/5869 as well. > > Unless the link is published anywhere, it won't do any harm. If you want us to > change or remove it, please request so in a ticket. Created a ticket for removing the redirection introduced previously -> https://issues.adblockplus.org/ticket/5958
LGTM. 
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
