Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29592643: #2956 - Fix forum sessions and login (Closed)

Created:
Oct. 30, 2017, 6:12 p.m. by f.lopez
Modified:
Nov. 2, 2017, 7:24 p.m.
Reviewers:
mathias, f.nicolaisen
Visibility:
Public.

Description

#2956 - Fix forum sessions and login

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/web/templates/adblockplus.org.conf.erb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
f.lopez
Oct. 30, 2017, 6:12 p.m. (2017-10-30 18:12:58 UTC) #1
mathias
Again, this hot-fix was already removed and supposed to stay that way.
Oct. 30, 2017, 7:24 p.m. (2017-10-30 19:24:23 UTC) #2
f.lopez
On 2017/10/30 19:24:23, mathias wrote: > Again, this hot-fix was already removed and supposed to ...
Oct. 30, 2017, 7:50 p.m. (2017-10-30 19:50:27 UTC) #3
f.nicolaisen
On 2017/10/30 19:50:27, f.lopez wrote: > On 2017/10/30 19:24:23, mathias wrote: > > Again, this ...
Oct. 30, 2017, 8:02 p.m. (2017-10-30 20:02:57 UTC) #4
mathias
Remove the hot-fix. Do not patch it back in.
Nov. 2, 2017, 10:39 a.m. (2017-11-02 10:39:16 UTC) #5
f.lopez
On 2017/11/02 10:39:16, mathias wrote: > Remove the hot-fix. Do not patch it back in. ...
Nov. 2, 2017, 7:24 p.m. (2017-11-02 19:24:36 UTC) #6
f.lopez
Nov. 2, 2017, 7:24 p.m. (2017-11-02 19:24:50 UTC) #7
Message was sent while issue was closed.
On 2017/11/02 19:24:36, f.lopez wrote:
> On 2017/11/02 10:39:16, mathias wrote:
> > Remove the hot-fix. Do not patch it back in.
> 
> I'm closing this codereview since this shouldn't be pushed.

oh, I just saw this is closed already...

Powered by Google App Engine
This is Rietveld