#4846 - Redirect non-matched requests to new redirects service

#4846 - Redirect non-matched requests to new redirects service

[mathias, 2017-11-03 12:38:13]

https://codereview.adblockplus.org/29596592/diff/29596593/modules/web/templat...
File modules/web/templates/adblockplus.org.conf.erb (right):

https://codereview.adblockplus.org/29596592/diff/29596593/modules/web/templat...
modules/web/templates/adblockplus.org.conf.erb:358: rewrite ^
$scheme://adblockplus.to/$arg_link/legacy_redirect redirect;
I do not like the `/legacy_redirect` part. It looks like unnecessary CO2
production to me. Why should `adblockplus.org/redirect?link=foobar` not redirect
to `adblockplus.to/foobar`?

If we find that it makes sense to designate the heritage in similar fashion
after all (which I am not convinced of, but for the sake of argument), I would
suggest something that avoids the bytes which do not transport information
(`_redirect`) and in general put the classification first
(`adblockplus.to/legacy/$arg_link`).

[f.nicolaisen, 2017-11-03 12:54:04]

https://codereview.adblockplus.org/29596592/diff/29596593/modules/web/templat...
File modules/web/templates/adblockplus.org.conf.erb (right):

https://codereview.adblockplus.org/29596592/diff/29596593/modules/web/templat...
modules/web/templates/adblockplus.org.conf.erb:358: rewrite ^
$scheme://adblockplus.to/$arg_link/legacy_redirect redirect;
On 2017/11/03 12:38:13, mathias wrote:
> I do not like the `/legacy_redirect` part. It looks like unnecessary CO2
> production to me. Why should `adblockplus.org/redirect?link=foobar` not
redirect
> to `adblockplus.to/foobar`?

My idea was that this would be valuable for tracking usage before eventually
sunsetting the old redirect endpoint. This way we can use the new stats produced
for eyeo.to to track how much the old redirects are being used (and from where
they come).

> If we find that it makes sense to designate the heritage in similar fashion
> after all (which I am not convinced of, but for the sake of argument), I would
> suggest something that avoids the bytes which do not transport information
> (`_redirect`) and in general put the classification first
> (`adblockplus.to/legacy/$arg_link`).

Would that still be forward-compatible with using the new redirects URLs? As an
example, from #4687, I need this URL for whatever legacy reasons:

    adblockplus.org/redirect?link=privacy_friendly_ads

However, I also want to start using the new, nicer URL:

    adblockplus.to/privacy_friendly_ads

This would require a single entry in the eyeo.to hiera data (given this patch),
and I get a nice URL to share around, which makes it easier to convince
developers that they should use the new redirect service as well.

If we would require the /legacy/ classification, I would get the uglier
adblockplus.to/legacy/privacy_friendly_ads URL, and/or I would have to add a
second hiera entry for the "modern" redirect
adblockplus.to/privacy_friendly_ads. Unless I'm misunderstanding..

[f.nicolaisen, 2017-11-03 13:23:41]

https://codereview.adblockplus.org/29596592/diff/29596593/modules/web/templat...
File modules/web/templates/adblockplus.org.conf.erb (right):

https://codereview.adblockplus.org/29596592/diff/29596593/modules/web/templat...
modules/web/templates/adblockplus.org.conf.erb:358: rewrite ^
$scheme://adblockplus.to/$arg_link/legacy_redirect redirect;
On 2017/11/03 12:38:13, mathias wrote:
> ...
> I would
> suggest something that avoids the bytes which do not transport information
> (`_redirect`)

Addressed this in PS2.

[mathias, 2017-11-07 20:20:53]

LGTM.

[mathias, 2017-11-07 20:20:54]

LGTM.