Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/filter/ElemHideEmulationFilter.cpp

Issue 29613616: Issue 6064 - Put C++ code into a configurable namespace (Closed) Base URL: https://github.com/adblockplus/adblockpluscore.git
Patch Set: Fix debug.h to be aligned with assert2 (define vs function) and get rid of a warning in generator.cpp Created Nov. 21, 2017, 2:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiled/filter/ElemHideEmulationFilter.cpp
diff --git a/compiled/filter/ElemHideEmulationFilter.cpp b/compiled/filter/ElemHideEmulationFilter.cpp
index 4c1c06e7a1043ae5ca91ff23078e5ebd0b55c976..962ca0b3d021f00df0f0dd47af72e810d3cf978b 100644
--- a/compiled/filter/ElemHideEmulationFilter.cpp
+++ b/compiled/filter/ElemHideEmulationFilter.cpp
@@ -17,6 +17,8 @@
#include "ElemHideEmulationFilter.h"
+ABP_NS_USING
hub 2017/11/21 16:48:39 This should be ABP_NS_BEGIN (and have the matching
sergei 2017/11/22 09:39:27 Could you please explain the advantage of wrapping
+
ElemHideEmulationFilter::ElemHideEmulationFilter(const String& text,
const ElemHideData& data)
: ElemHideBase(Type::ELEMHIDEEMULATION, text, data)

Powered by Google App Engine
This is Rietveld