Issue 29615617: Issue 6074 - Added checkbox.svg to the Firefox builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29615617: Issue 6074 - Added checkbox.svg to the Firefox builds (Closed)

Created:
Nov. 22, 2017, 12:51 p.m. by saroyanm

Modified:
Nov. 22, 2017, 1:24 p.m.

Reviewers:
kzar

CC:
Thomas Greiner

Visibility:
Public.

Description

Issue 6074 - Added checkbox.svg to the Firefox builds

Patch Set 1 #

Total comments: 3

Created: Nov. 22, 2017, 12:51 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	metadata.gecko	View		1 chunk	+1 line, -0 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

saroyanm

Ready for review. https://codereview.adblockplus.org/29615617/diff/29615618/metadata.gecko File metadata.gecko (right): https://codereview.adblockplus.org/29615617/diff/29615618/metadata.gecko#newcode32 metadata.gecko:32: skin/icons/checkbox.png = adblockplusui/skin/icons/checkbox.png Note: checkbox.png is ...

Nov. 22, 2017, 12:54 p.m. (2017-11-22 12:54:20 UTC) #1

kzar

Have you tested the fix works? https://codereview.adblockplus.org/29615617/diff/29615618/metadata.gecko File metadata.gecko (right): https://codereview.adblockplus.org/29615617/diff/29615618/metadata.gecko#newcode32 metadata.gecko:32: skin/icons/checkbox.png = adblockplusui/skin/icons/checkbox.png ...

Nov. 22, 2017, 12:55 p.m. (2017-11-22 12:55:01 UTC) #2

saroyanm

Yes, tested and it works. https://codereview.adblockplus.org/29615617/diff/29615618/metadata.gecko File metadata.gecko (right): https://codereview.adblockplus.org/29615617/diff/29615618/metadata.gecko#newcode32 metadata.gecko:32: skin/icons/checkbox.png = adblockplusui/skin/icons/checkbox.png On ...

Nov. 22, 2017, 1:03 p.m. (2017-11-22 13:03:57 UTC) #3

Fair enough, LGTM

Expand All Messages | Collapse All Messages