Issue 29632971: #5944 - Use abpssembly to update update manifests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29632971: #5944 - Use abpssembly to update update manifests (Closed)

Created:
Dec. 7, 2017, 2:46 p.m. by mathias

Modified:
Dec. 7, 2017, 5:13 p.m.

Reviewers:
f.lopez

CC:
tlucas, Vasily Kuznetsov, Fred, f.nicolaisen

Visibility:
Public.

Description

See also https://codereview.adblockplus.org/29632576/ --

Patch Set 1 #

Created: Dec. 7, 2017, 2:46 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -16 lines)			Patch
M	modules/private-stub/files/adblockplussafari.pem	View	1 chunk	+82 lines, -15 lines	0 comments	Download
M	modules/updateserver/manifests/init.pp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	modules/updateserver/templates/update_update_manifests.erb	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

f.lopez

On 2017/12/07 14:46:50, mathias wrote: I don't see where the key is used... am I ...

Dec. 7, 2017, 3:18 p.m. (2017-12-07 15:18:04 UTC) #2

mathias

On 2017/12/07 15:18:04, f.lopez wrote: > I don't see where the key is used... am ...

Dec. 7, 2017, 3:22 p.m. (2017-12-07 15:22:55 UTC) #3

f.lopez

Dec. 7, 2017, 3:26 p.m. (2017-12-07 15:26:47 UTC) #4

On 2017/12/07 15:22:55, mathias wrote:
> On 2017/12/07 15:18:04, f.lopez wrote:
> > I don't see where the key is used... am I missing something here?
> 
> The updateUpdateManfiests.py script requires the KEY in the PEM, which changed
> some time ago and was only updated in production config, not here in
> development, where it was broken ever since and just surfaced today. It's an
> implicit fix, but does not affect anything relevant outside of testing.

LGTM then

Expand All Messages | Collapse All Messages