Issue 29649555: Issue 6219 - Create flavors per ABI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29649555: Issue 6219 - Create flavors per ABI (Closed)

Created:
Dec. 26, 2017, 2:19 p.m. by anton

Modified:
Jan. 10, 2018, 7:17 p.m.

Reviewers:
René Jeschke, diegocarloslima, jens

CC:
sergei

Visibility:
Public.

Patch Set 2 : renamed variable #

Created: Jan. 9, 2018, 6:20 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -11 lines)			Patch
M	README.md	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	build.gradle	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
M	libadblockplus-android-settings/build.gradle	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	libadblockplus-android-tests/build.gradle	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	libadblockplus-android-webview/build.gradle	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	libadblockplus-android-webviewapp/build.gradle	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	libadblockplus-android/build.gradle	View		1 chunk	+32 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

diegocarloslima

On 2017/12/26 14:21:28, anton wrote: LGTM, with a minor comment

Jan. 3, 2018, 11:41 a.m. (2018-01-03 11:41:54 UTC) #2

diegocarloslima

https://codereview.adblockplus.org/29649555/diff/29649556/build.gradle File build.gradle (right): https://codereview.adblockplus.org/29649555/diff/29649556/build.gradle#newcode7 build.gradle:7: String tskReqStr = gradle.getStartParameter().getTaskRequests().toString() Minor thing, but I think ...

Jan. 3, 2018, 11:42 a.m. (2018-01-03 11:42:02 UTC) #3

anton

Jan. 9, 2018, 6:20 a.m. (2018-01-09 06:20:41 UTC) #4

jens

Jan. 10, 2018, 2:18 p.m. (2018-01-10 14:18:11 UTC) #5

On 2018/01/09 06:20:41, anton wrote:
> https://codereview.adblockplus.org/29649555/diff/29649556/build.gradle
> File build.gradle (right):
> 
>
https://codereview.adblockplus.org/29649555/diff/29649556/build.gradle#newcode7
> build.gradle:7: String  tskReqStr =
> gradle.getStartParameter().getTaskRequests().toString()
> On 2018/01/03 11:42:02, diegocarloslima wrote:
> > Minor thing, but I think it would be better to rename the variable to
> > `taskReqStr`
> 
> Acknowledged.

LGTM

Expand All Messages | Collapse All Messages