Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29657626: Issue 5943 - Text in the review/specs and requested text difference (Closed)

Created:
Jan. 5, 2018, 1:39 p.m. by saroyanm
Modified:
Jan. 29, 2018, 4:18 p.m.
Reviewers:
Visibility:
Public.

Description

Issue 5943 - Text in the review/specs and requested text difference

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M locale/en_US/updates.json View 3 chunks +3 lines, -3 lines 8 comments Download

Messages

Total messages: 1
saroyanm
Jan. 5, 2018, 1:58 p.m. (2018-01-05 13:58:18 UTC) #1
https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
File locale/en_US/updates.json (right):

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:3: "message": "Update complete"
Capitalization is minor.

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:12: "message": "Brand new Settings page - revamped and
restyled with more privacy and security options - so it's easier to customize
Adblock Plus just like you want it. [Check it out for yourself.]"
The text is different.

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:12: "message": "Brand new Settings page - revamped and
restyled with more privacy and security options - so it's easier to customize
Adblock Plus just like you want it. [Check it out for yourself.]"
"[" "]" Difference is minor this will be replaced in original text and
translations with <a> </a>

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:12: "message": "Brand new Settings page - revamped and
restyled with more privacy and security options - so it's easier to customize
Adblock Plus just like you want it. [Check it out for yourself.]"
"." is inconsistent.

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:12: "message": "Brand new Settings page - revamped and
restyled with more privacy and security options - so it's easier to customize
Adblock Plus just like you want it. [Check it out for yourself.]"
This text matches with the Specification.. So the original text should be
changed.

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:21: "message": "If you are taking control on desktop,
you can block ads and improve your privacy and security on mobile too. Get the
[Adblock Browser App below]"
"[" "]" Difference is minor this will be replaced in original text and
translations with <a> </a>

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:21: "message": "If you are taking control on desktop,
you can block ads and improve your privacy and security on mobile too. Get the
[Adblock Browser App below]"
"are" and "like" looks to be minor, but I'll leave it up to C&T to decide. Same
goes to punctuation.

https://codereview.adblockplus.org/29657626/diff/29657627/locale/en_US/update...
locale/en_US/updates.json:21: "message": "If you are taking control on desktop,
you can block ads and improve your privacy and security on mobile too. Get the
[Adblock Browser App below]"
This text matches with the Specifications, so the original text should be
changed.

Powered by Google App Engine
This is Rietveld