Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29680702: Issue 6008 - Expose updates version via lib/prefs.js (Closed)

Created:
Jan. 26, 2018, 6:07 p.m. by Thomas Greiner
Modified:
Jan. 31, 2018, 11:45 a.m.
Reviewers:
saroyanm
CC:
kzar
Visibility:
Public.

Description

This change exposes the updates version to the extension so that it can decide whether or not the updates page should be shown. See also https://codereview.adblockplus.org/29664623/ for related changes to adblockpluschrome.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed lib/ui.js to lib/prefs.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A lib/prefs.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Jan. 26, 2018, 6:10 p.m. (2018-01-26 18:10:50 UTC) #1
saroyanm
https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js#newcode1 lib/ui.js:1: /* All looks fine and I don't want to ...
Jan. 30, 2018, 3 p.m. (2018-01-30 15:00:41 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js#newcode1 lib/ui.js:1: /* On 2018/01/30 15:00:40, saroyanm wrote: > All looks ...
Jan. 30, 2018, 6:20 p.m. (2018-01-30 18:20:39 UTC) #3
saroyanm
Jan. 31, 2018, 10:24 a.m. (2018-01-31 10:24:27 UTC) #4
LGTM considering that the https://codereview.adblockplus.org/29664623 review
will be updated accordingly.

Powered by Google App Engine
This is Rietveld