Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29685561: Issue 5864 - Specify CSS group name for standard filters (Closed)

Created:
Jan. 31, 2018, 8:31 a.m. by Manish Jethani
Modified:
Jan. 31, 2018, 12:10 p.m.
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

We forgot to do this in https://codereview.adblockplus.org/29575739/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/cssInjection.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Manish Jethani
Jan. 31, 2018, 8:31 a.m. (2018-01-31 08:31:11 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29575739/
Jan. 31, 2018, 8:32 a.m. (2018-01-31 08:32:45 UTC) #2
Manish Jethani
On 2018/01/31 08:32:45, Manish Jethani wrote: > Patch Set 1 > > https://codereview.adblockplus.org/29575739/ I mean ...
Jan. 31, 2018, 8:33 a.m. (2018-01-31 08:33:34 UTC) #3
kzar
Jan. 31, 2018, 11:18 a.m. (2018-01-31 11:18:50 UTC) #4
You could also give the commit message the issue number of 5864 but I don't care
much either way. This LGTM anyway.

Powered by Google App Engine
This is Rietveld