Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29691616: #5080 - Extend fileserver::repository to optionally create repository users (Closed)

Created:
Feb. 7, 2018, 2:48 p.m. by Fred
Modified:
March 15, 2018, 5:58 p.m.
Reviewers:
f.lopez, mathias
Visibility:
Public.

Description

#5080 - Extend fileserver::repository to optionally create repository users

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use quotes around the type name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/adblockplus/manifests/web/fileserver/repository.pp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Fred
Feb. 7, 2018, 2:48 p.m. (2018-02-07 14:48:43 UTC) #1
mathias
https://codereview.adblockplus.org/29691616/diff/29691617/modules/adblockplus/manifests/web/fileserver/repository.pp File modules/adblockplus/manifests/web/fileserver/repository.pp (right): https://codereview.adblockplus.org/29691616/diff/29691617/modules/adblockplus/manifests/web/fileserver/repository.pp#newcode44 modules/adblockplus/manifests/web/fileserver/repository.pp:44: ensure_resources(adblockplus::user, $users, { Please use quotes (') around the ...
March 5, 2018, 3:28 p.m. (2018-03-05 15:28:35 UTC) #2
Fred
Use quotes around the type name
March 8, 2018, 9:15 a.m. (2018-03-08 09:15:06 UTC) #3
Fred
https://codereview.adblockplus.org/29691616/diff/29691617/modules/adblockplus/manifests/web/fileserver/repository.pp File modules/adblockplus/manifests/web/fileserver/repository.pp (right): https://codereview.adblockplus.org/29691616/diff/29691617/modules/adblockplus/manifests/web/fileserver/repository.pp#newcode44 modules/adblockplus/manifests/web/fileserver/repository.pp:44: ensure_resources(adblockplus::user, $users, { On 2018/03/05 15:28:35, mathias wrote: > ...
March 8, 2018, 9:16 a.m. (2018-03-08 09:16:11 UTC) #4
mathias
March 8, 2018, 10:09 a.m. (2018-03-08 10:09:55 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld