desktop-options.html - Issue 29714596: Issue 6440 - Disable common textarea features to improve performance

Delta Between Two Patch Sets: desktop-options.html

Issue 29714596: Issue 6440 - Disable common textarea features to improve performance (Closed)

Left Patch Set: Created March 5, 2018, 4:17 p.m.

Right Patch Set: Created March 5, 2018, 5:33 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 - This file is part of Adblock Plus <https://adblockplus.org/>,	3 - This file is part of Adblock Plus <https://adblockplus.org/>,

4 - Copyright (C) 2006-present eyeo GmbH	4 - Copyright (C) 2006-present eyeo GmbH

5 -	5 -

6 - Adblock Plus is free software: you can redistribute it and/or modify	6 - Adblock Plus is free software: you can redistribute it and/or modify

7 - it under the terms of the GNU General Public License version 3 as	7 - it under the terms of the GNU General Public License version 3 as

8 - published by the Free Software Foundation.	8 - published by the Free Software Foundation.

9 -	9 -

10 - Adblock Plus is distributed in the hope that it will be useful,	10 - Adblock Plus is distributed in the hope that it will be useful,

(...skipping 283 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
294 <div id="custom-filters">	294 <div id="custom-filters">

295 <h3 class="i18n_options_customFilters_widget_title"></h3>	295 <h3 class="i18n_options_customFilters_widget_title"></h3>

296 <div id="empty-custom-filters">	296 <div id="empty-custom-filters">

297 <p class="i18n_options_customFilters_tip"></p>	297 <p class="i18n_options_customFilters_tip"></p>

298 <button class="i18n_options_customFilters_start primary" data-acti on="edit-custom-filters">	298 <button class="i18n_options_customFilters_start primary" data-acti on="edit-custom-filters">

299 </button>	299 </button>

300 <p>	300 <p>

301 <a class="i18n_options_customFilters_learn" id="link-filters" ta rget="_blank"></a>	301 <a class="i18n_options_customFilters_learn" id="link-filters" ta rget="_blank"></a>

302 </p>	302 </p>

303 </div>	303 </div>

304 <textarea id="custom-filters-raw" rows="15" spellcheck="false"	304 <textarea id="custom-filters-raw" rows="15" spellcheck="false" autoc omplete="off"></textarea>

305 autocapitalize="off" autocomplete="off" autocorrect="off"> </textarea>
Thomas Greiner 2018/03/05 16:40:57 According to https://developer.mozilla.org/en-US/d According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-autoc... "autocapitalize" is only supported by WebKit on iOS so it's not relevant for us. I haven't found any documentation about "autocorrect" though so that may be another non-standard attribute that doesn't apply to us. Based on the sources I found, most of them are referring to iOS so presumably this one is also only supported by WebKit on iOS. a.giammarchi 2018/03/05 16:54:43 but it doesn't hurt having it in, right? Show quoted text On 2018/03/05 16:40:57, Thomas Greiner wrote: > According to > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-autoc... > "autocapitalize" is only supported by WebKit on iOS so it's not relevant for us. but it doesn't hurt having it in, right? Show quoted text > I haven't found any documentation about "autocorrect" though so that may be > another non-standard attribute that doesn't apply to us. Based on the sources I > found, most of them are referring to iOS so presumably this one is also only > supported by WebKit on iOS. I've used all attributes that uBo uses as shown in the ticket: https://issues.adblockplus.org/attachment/ticket/6440/ubo%20textarea%20code%2... plus I've added everything that could bother any browser. Since there's no hurt in having those attributes in, and if browsers will ever implement those we'll be already prepared for that, are we sure we don't want to just be preemptively sure we disable those features?
306 <div class="side-controls">	305 <div class="side-controls">

307 <button id="custom-filters-edit" class="i18n_options_customFilter_ edit secondary" data-action="edit-custom-filters">	306 <button id="custom-filters-edit" class="i18n_options_customFilter_ edit secondary" data-action="edit-custom-filters">

308 </button>	307 </button>

309 <div class="side-controls" id="custom-filters-raw-controls">	308 <div class="side-controls" id="custom-filters-raw-controls">

310 <button class="i18n_options_customFilter_cancel secondary" data- action="cancel-custom-filters"></button>	309 <button class="i18n_options_customFilter_cancel secondary" data- action="cancel-custom-filters"></button>

311 <button class="i18n_options_customFilter_save primary" data-acti on="save-custom-filters"></button>	310 <button class="i18n_options_customFilter_save primary" data-acti on="save-custom-filters"></button>

312 </div>	311 </div>

313 </div>	312 </div>

314 </div>	313 </div>

315 </section>	314 </section>

(...skipping 115 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
431 </div>	430 </div>

432 <!-- Notification -->	431 <!-- Notification -->

433 <div id="notification" aria-hidden="true" aria-live="polite">	432 <div id="notification" aria-hidden="true" aria-live="polite">

434 <strong id="notification-text"></strong>	433 <strong id="notification-text"></strong>

435 <button class="icon close secondary" data-action="hide-notification">	434 <button class="icon close secondary" data-action="hide-notification">

436 <span class="i18n_options_notification_hide sr-only"></span>	435 <span class="i18n_options_notification_hide sr-only"></span>

437 </button>	436 </button>

438 </div>	437 </div>

439 </body>	438 </body>

440 </html>	439 </html>

LEFT	RIGHT