Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29714596: Issue 6440 - Disable common textarea features to improve performance (Closed)

Created:
March 5, 2018, 4:17 p.m. by a.giammarchi
Modified:
March 6, 2018, 12:47 p.m.
Reviewers:
Thomas Greiner
CC:
saroyanm
Visibility:
Public.

Description

Issue 6440 - Disable common textarea features to improve performance

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M desktop-options.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Thomas Greiner
https://codereview.adblockplus.org/29714596/diff/29714597/desktop-options.html File desktop-options.html (right): https://codereview.adblockplus.org/29714596/diff/29714597/desktop-options.html#newcode305 desktop-options.html:305: autocapitalize="off" autocomplete="off" autocorrect="off"></textarea> According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attr-autocapitalize "autocapitalize" is only ...
March 5, 2018, 4:40 p.m. (2018-03-05 16:40:57 UTC) #1
a.giammarchi
https://codereview.adblockplus.org/29714596/diff/29714597/desktop-options.html File desktop-options.html (right): https://codereview.adblockplus.org/29714596/diff/29714597/desktop-options.html#newcode305 desktop-options.html:305: autocapitalize="off" autocomplete="off" autocorrect="off"></textarea> On 2018/03/05 16:40:57, Thomas Greiner wrote: ...
March 5, 2018, 4:54 p.m. (2018-03-05 16:54:43 UTC) #2
a.giammarchi
actually I'm OK with keeping it clean since we'll replace the textarea hopefulyl before any ...
March 5, 2018, 5:34 p.m. (2018-03-05 17:34:49 UTC) #3
Thomas Greiner
March 6, 2018, 11:53 a.m. (2018-03-06 11:53:50 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld