Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsEngine.cpp

Issue 29734562: Issue 6526 - update usage of V8 API (Closed) Base URL: https://github.com/adblockplus/libadblockplus@18cc8b26874862bdc75c1cce28bd7b490066c659
Patch Set: Created March 27, 2018, 11:37 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/FileSystemJsObject.cpp ('k') | src/JsValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsEngine.cpp
diff --git a/src/JsEngine.cpp b/src/JsEngine.cpp
index 9e540a57cd07b339923772854d57a4b9289dea83..a2bcf9a423d94a86955c97cf4597d243e1e1306a 100644
--- a/src/JsEngine.cpp
+++ b/src/JsEngine.cpp
@@ -190,7 +190,7 @@ AdblockPlus::JsValue AdblockPlus::JsEngine::Evaluate(const std::string& source,
const std::string& filename)
{
const JsContext context(*this);
- const v8::TryCatch tryCatch;
+ const v8::TryCatch tryCatch(GetIsolate());
const v8::Handle<v8::Script> script = CompileScript(GetIsolate(), source,
filename);
CheckTryCatch(tryCatch);
@@ -232,7 +232,7 @@ void AdblockPlus::JsEngine::TriggerEvent(const std::string& eventName, AdblockPl
void AdblockPlus::JsEngine::Gc()
{
- while (!GetIsolate()->IdleNotification(1000));
+ while (!GetIsolate()->IdleNotificationDeadline(1000));
}
AdblockPlus::JsValue AdblockPlus::JsEngine::NewValue(const std::string& val)
« no previous file with comments | « src/FileSystemJsObject.cpp ('k') | src/JsValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld