Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsValue.cpp

Issue 29734562: Issue 6526 - update usage of V8 API (Closed) Base URL: https://github.com/adblockplus/libadblockplus@18cc8b26874862bdc75c1cce28bd7b490066c659
Patch Set: Created March 27, 2018, 11:37 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/JsEngine.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsValue.cpp
diff --git a/src/JsValue.cpp b/src/JsValue.cpp
index 55ee092464e65b34fce92c20d5ad69e4ac9664be..3934cc18634eaafdad756c9b61867b4a75bce6d3 100644
--- a/src/JsValue.cpp
+++ b/src/JsValue.cpp
@@ -284,7 +284,7 @@ JsValue JsValue::Call(std::vector<v8::Handle<v8::Value>>& args, v8::Local<v8::Ob
const JsContext context(*jsEngine);
- const v8::TryCatch tryCatch;
+ const v8::TryCatch tryCatch(jsEngine->GetIsolate());
v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
v8::Local<v8::Value> result = func->Call(thisObj, args.size(),
args.size() ? &args[0] : nullptr);
« no previous file with comments | « src/JsEngine.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld