Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29754599: #10198 - Redirect abp.org/devbuilds to /development-builds (Closed)

Created:
April 17, 2018, 10:38 p.m. by f.lopez
Modified:
April 18, 2018, 6:54 p.m.
Reviewers:
mathias, Fred
Visibility:
Public.

Description

#10198 - Redirect abp.org/devbuilds to /development-builds

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 and 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M modules/web/templates/adblockplus.org.conf.erb View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
f.lopez
April 17, 2018, 10:38 p.m. (2018-04-17 22:38:09 UTC) #1
mathias
https://codereview.adblockplus.org/29754599/diff/29754600/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): https://codereview.adblockplus.org/29754599/diff/29754600/modules/web/templates/adblockplus.org.conf.erb#newcode91 modules/web/templates/adblockplus.org.conf.erb:91: rewrite ^/(devbuilds)/?$ https://adblockplus.org/development-builds permanent; Why the surrounding `()`? And ...
April 17, 2018, 10:49 p.m. (2018-04-17 22:49:51 UTC) #2
f.lopez
On 2018/04/17 22:49:51, mathias wrote: > https://codereview.adblockplus.org/29754599/diff/29754600/modules/web/templates/adblockplus.org.conf.erb > File modules/web/templates/adblockplus.org.conf.erb (right): > > https://codereview.adblockplus.org/29754599/diff/29754600/modules/web/templates/adblockplus.org.conf.erb#newcode91 > ...
April 17, 2018, 11:43 p.m. (2018-04-17 23:43:30 UTC) #3
f.lopez
April 17, 2018, 11:44 p.m. (2018-04-17 23:44:27 UTC) #4
mathias
April 18, 2018, 2:13 a.m. (2018-04-18 02:13:06 UTC) #5
lgtm.

Powered by Google App Engine
This is Rietveld