Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29756808: Issue 6597 - Update libadblockplus dependency to revision hg:a11c50751bfd (Closed)

Created:
April 19, 2018, 8:02 p.m. by anton
Modified:
April 20, 2018, 8:28 a.m.
CC:
sergei
Visibility:
Public.

Description

Issue 6597 - Update libadblockplus dependency to revision hg:a11c50751bfd

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixed versionCode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M README.md View 1 chunk +2 lines, -2 lines 0 comments Download
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android-webviewapp/build.gradle View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android/build.gradle View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android/jni/Android.mk View 1 chunk +3 lines, -1 line 0 comments Download
M libadblockplus-android/jni/Application.mk View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
anton
https://codereview.adblockplus.org/29756808/diff/29756809/README.md File README.md (right): https://codereview.adblockplus.org/29756808/diff/29756809/README.md#newcode23 README.md:23: * Android SDK Build tools 25.0.0 honestly this is ...
April 19, 2018, 8:05 p.m. (2018-04-19 20:05:20 UTC) #1
jens
https://codereview.adblockplus.org/29756808/diff/29756809/README.md File README.md (right): https://codereview.adblockplus.org/29756808/diff/29756809/README.md#newcode23 README.md:23: * Android SDK Build tools 25.0.0 On 2018/04/19 20:05:20, ...
April 20, 2018, 7:46 a.m. (2018-04-20 07:46:31 UTC) #2
anton
https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-android-webviewapp/build.gradle File libadblockplus-android-webviewapp/build.gradle (right): https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-android-webviewapp/build.gradle#newcode23 libadblockplus-android-webviewapp/build.gradle:23: versionCode 7 On 2018/04/20 07:46:31, jens wrote: > Shouldn't ...
April 20, 2018, 8:13 a.m. (2018-04-20 08:13:12 UTC) #3
anton
On 2018/04/20 08:13:12, anton wrote: > https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-android-webviewapp/build.gradle > File libadblockplus-android-webviewapp/build.gradle (right): > > https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-android-webviewapp/build.gradle#newcode23 > ...
April 20, 2018, 8:14 a.m. (2018-04-20 08:14:31 UTC) #4
jens
On 2018/04/20 08:14:31, anton wrote: > On 2018/04/20 08:13:12, anton wrote: > > > https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-android-webviewapp/build.gradle ...
April 20, 2018, 8:16 a.m. (2018-04-20 08:16:10 UTC) #5
diegocarloslima
April 20, 2018, 8:25 a.m. (2018-04-20 08:25:28 UTC) #6 
On 2018/04/20 08:16:10, jens wrote:
> On 2018/04/20 08:14:31, anton wrote:
> > On 2018/04/20 08:13:12, anton wrote:
> > >
> >
>
https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-andr...
> > > File libadblockplus-android-webviewapp/build.gradle (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-andr...
> > > libadblockplus-android-webviewapp/build.gradle:23: versionCode 7
> > > On 2018/04/20 07:46:31, jens wrote:
> > > > Shouldn't you also bump the versionCode?
> > > 
> > > Acknowledged.
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-andr...
> > > File libadblockplus-android/build.gradle (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29756808/diff/29756809/libadblockplus-andr...
> > > libadblockplus-android/build.gradle:10: versionCode 4
> > > On 2018/04/20 07:46:31, jens wrote:
> > > > Shouldn't you also bump the versionCode?
> > > 
> > > Acknowledged.
> > 
> > Uploaded patch set #2
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld