Issue 29768621: #10639 - node-sass output filter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29768621: #10639 - node-sass output filter (Closed)

Created:
May 2, 2018, 12:48 p.m. by l.rosilio

Modified:
July 2, 2018, 2:21 p.m.

Reviewers:
f.lopez, mathias, Fred

Visibility:
Public.

Patch Set 2 : #10639 - node-sass output filter #

Patch Set 3 : #10639 - node-sass output filter #

Total comments: 1

Patch Set 4 : #10639 - node-sass output filter #

Total comments: 2

Patch Set 5 : #10639 - node-sass output filter #

Created: June 20, 2018, 12:34 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	A	edit.sh	View	1 2 3 4	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

mathias

https://codereview.adblockplus.org/29768621/diff/29804566/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29768621/diff/29804566/edit.sh#newcode7 edit.sh:7: *Rendering*|*Wrote*) Can't you make these patterns more specific, in ...

June 11, 2018, 2:04 p.m. (2018-06-11 14:04:14 UTC) #4

mathias

Almost there :) https://codereview.adblockplus.org/29768621/diff/29805567/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29768621/diff/29805567/edit.sh#newcode7 edit.sh:7: *Rendering?Complete,?saving*file*|*Wrote?CSS?to?*) As discussed: Please remove the ...

June 19, 2018, 12:59 p.m. (2018-06-19 12:59:49 UTC) #6

LGTM.

Expand All Messages | Collapse All Messages