Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29784619: #11294 - Apply workaround for broken pip package in Debian "jessie" (Closed)

Created:
May 18, 2018, 12:28 a.m. by mathias
Modified:
May 22, 2018, 3:36 p.m.
Reviewers:
f.lopez, Fred
Visibility:
Public.

Description

#11294 - Apply workaround for broken pip package in Debian "jessie"

Patch Set 1 #

Total comments: 1

Patch Set 2 : #11294 - Address feedback from codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M manifests/site.pp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M modules/adblockplus/manifests/legacy.pp View 1 1 chunk +23 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/base.yaml View 1 1 chunk +0 lines, -1 line 0 comments Download
M modules/trac/manifests/init.pp View 1 1 chunk +1 line, -1 line 0 comments Download
M modules/updateserver/manifests/init.pp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M modules/web/manifests/server.pp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
mathias
May 18, 2018, 12:28 a.m. (2018-05-18 00:28:43 UTC) #1
f.lopez
https://codereview.adblockplus.org/29784619/diff/29784620/manifests/site.pp File manifests/site.pp (left): https://codereview.adblockplus.org/29784619/diff/29784620/manifests/site.pp#oldcode17 manifests/site.pp:17: please don't introduce unrelated changes
May 18, 2018, 1:28 a.m. (2018-05-18 01:28:49 UTC) #2
mathias
May 18, 2018, 1:29 a.m. (2018-05-18 01:29:44 UTC) #3
f.lopez
May 18, 2018, 1:36 a.m. (2018-05-18 01:36:47 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld