Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29790614: #11512 - Configure eyeo.to/partner-privacy-policy redirect (Closed)

Created:
May 25, 2018, 10:05 a.m. by Fred
Modified:
May 30, 2018, 8:12 a.m.
Reviewers:
mathias
CC:
f.lopez
Visibility:
Public.

Description

#11512 - Configure eyeo.to/partner-privacy-policy redirect

Patch Set 1 #

Patch Set 2 : Chose a different target server #

Total comments: 1

Patch Set 3 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M hiera/roles/web/redirect/eyeo.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Fred
May 25, 2018, 10:05 a.m. (2018-05-25 10:05:27 UTC) #1
Fred
Chose a different target server
May 25, 2018, 10:23 a.m. (2018-05-25 10:23:13 UTC) #2
mathias
https://codereview.adblockplus.org/29790614/diff/29790617/hiera/roles/web/redirect/eyeo.yaml File hiera/roles/web/redirect/eyeo.yaml (right): https://codereview.adblockplus.org/29790614/diff/29790617/hiera/roles/web/redirect/eyeo.yaml#newcode17 hiera/roles/web/redirect/eyeo.yaml:17: partner-privacy-policy "https://eyeofiles.com/eyeo_Partner_Information_GDPR.pdf" Isn't there a colon missing here?
May 25, 2018, 10:25 a.m. (2018-05-25 10:25:14 UTC) #3
Fred
Fixed typo
May 25, 2018, 10:40 a.m. (2018-05-25 10:40:00 UTC) #4
Fred
On 2018/05/25 10:25:14, mathias wrote: > https://codereview.adblockplus.org/29790614/diff/29790617/hiera/roles/web/redirect/eyeo.yaml > File hiera/roles/web/redirect/eyeo.yaml (right): > > https://codereview.adblockplus.org/29790614/diff/29790617/hiera/roles/web/redirect/eyeo.yaml#newcode17 > ...
May 25, 2018, 10:40 a.m. (2018-05-25 10:40:28 UTC) #5
mathias
May 25, 2018, 11:46 a.m. (2018-05-25 11:46:05 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld