Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29792555: Fixes #3 - Share app store buttons (Closed)

Created:
May 28, 2018, 10:58 a.m. by ire
Modified:
May 29, 2018, 3:52 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Fixes #3 - Share app store buttons

Patch Set 1 #

Patch Set 2 : Added documentatoin page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -0 lines) Patch
A locales/de/img/png/apple-app-store-badge.png View 1 Binary file 0 comments Download
A locales/de/img/png/google-play-badge.png View Binary file 0 comments Download
A locales/de/img/svg/apple-app-store-badge.svg View 1 chunk +40 lines, -0 lines 0 comments Download
A locales/en/img/png/apple-app-store-badge.png View 1 Binary file 0 comments Download
A locales/en/img/png/google-play-badge.png View Binary file 0 comments Download
A locales/en/img/svg/apple-app-store-badge.svg View 1 chunk +46 lines, -0 lines 0 comments Download
A locales/es/img/png/apple-app-store-badge.png View 1 Binary file 0 comments Download
A locales/es/img/png/google-play-badge.png View Binary file 0 comments Download
A locales/es/img/svg/apple-app-store-badge.svg View 1 chunk +47 lines, -0 lines 0 comments Download
A locales/fr/img/png/apple-app-store-badge.png View 1 Binary file 0 comments Download
A locales/fr/img/png/google-play-badge.png View Binary file 0 comments Download
A locales/fr/img/svg/apple-app-store-badge.svg View 1 chunk +50 lines, -0 lines 0 comments Download
A locales/ru/img/png/apple-app-store-badge.png View 1 Binary file 0 comments Download
A locales/ru/img/png/google-play-badge.png View Binary file 0 comments Download
A locales/ru/img/svg/apple-app-store-badge.svg View 1 chunk +43 lines, -0 lines 0 comments Download
A locales/zh/img/png/apple-app-store-badge.png View 1 Binary file 0 comments Download
A locales/zh/img/png/google-play-badge.png View Binary file 0 comments Download
A locales/zh/img/svg/apple-app-store-badge.svg View 1 chunk +29 lines, -0 lines 0 comments Download
A pages/images.md View 1 1 chunk +34 lines, -0 lines 0 comments Download
M pages/index.html View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
ire
May 28, 2018, 10:59 a.m. (2018-05-28 10:59:17 UTC) #1
ire
Ready for review! Notes: 1. There is no SVG version of the Google Play Badge ...
May 28, 2018, 11:17 a.m. (2018-05-28 11:17:12 UTC) #2
juliandoucette
On 2018/05/28 11:17:12, ire wrote: LGTM > 2. I'm starting to think we should namespace ...
May 29, 2018, 12:03 p.m. (2018-05-29 12:03:41 UTC) #3
juliandoucette
On 2018/05/29 12:03:41, juliandoucette wrote: > 2. I'm starting to think we should namespace things ...
May 29, 2018, 12:06 p.m. (2018-05-29 12:06:55 UTC) #4
ire
May 29, 2018, 3:50 p.m. (2018-05-29 15:50:39 UTC) #5
On 2018/05/29 12:06:55, juliandoucette wrote:
> On 2018/05/29 12:03:41, juliandoucette wrote:
> > 2. I'm starting to think we should namespace things from website-defaults.
So
> > instead of just `locales/en/img` it would be `locales/en/wd/img` so when we
> use
> > the image it'll be "wd/img/png/google-play-badge.png", what do you think? (I
> > think you suggested something like this before)
> 
> (I submitted prematurely by mistake.)
> 
> I'd prefer not to namespace resources inside the website-defaults repository.
> Instead, we may namespace a dependency in a website's settings.ini. I forget
> whether or not we have implemented this namespacing feature inside the CMS
yet.
> 
> Anyway, I think this implementation is good for now.

Ack. Namespacing via the settings.ini would be preferable anyway. Thanks!

Powered by Google App Engine
This is Rietveld