Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29802595: Issue 6664 - Update the buildtools dependency for adblockpluscore

Created:
June 8, 2018, 4:56 p.m. by tschuster
Modified:
June 12, 2018, 10:51 a.m.
Reviewers:
kzar
CC:
Manish Jethani
Visibility:
Public.

Description

Issue 6664 - Update the buildtools dependency for adblockpluscore

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -107 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 1 comment () Download
M ensure_dependencies.py View 12 chunks +171 lines, -106 lines 0 comments Download

Messages

Total messages: 2
tschuster
June 8, 2018, 4:57 p.m. (2018-06-08 16:57:00 UTC) #1
kzar
June 12, 2018, 10:51 a.m. (2018-06-12 10:51:13 UTC) #2
(I've also replied to the issue requesting some more details.)

https://codereview.adblockplus.org/29802595/diff/29802596/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29802595/diff/29802596/dependencies#newcode3
dependencies:3: buildtools = buildtools hg:c830dfa08e2f git:3a925dd
Please could you use the most recent buildtools revision?

Powered by Google App Engine
This is Rietveld