Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29811576: Noissue - set max screenshot width (Closed)

Created:
June 20, 2018, 1:33 p.m. by a.giammarchi
Modified:
July 5, 2018, 10:08 a.m.
Visibility:
Public.

Description

Avoid retina images to be viewed too big, and preserve their HiDPi quality.

Patch Set 1 #

Patch Set 2 : dropped spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M sitescripts/reports/static/reports.css View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12
a.giammarchi
P.S. I guess my automatic eyeo CSS linting rules applier worked as expected, explaining those ...
June 20, 2018, 1:37 p.m. (2018-06-20 13:37:15 UTC) #1
tlucas
Sorry for the confusion, i was thinking in "automation"-realms. However - Vasily should be the ...
June 20, 2018, 1:37 p.m. (2018-06-20 13:37:49 UTC) #2
Vasily Kuznetsov
On 2018/06/20 13:37:15, a.giammarchi wrote: > P.S. I guess my automatic eyeo CSS linting rules ...
June 21, 2018, 9:54 a.m. (2018-06-21 09:54:21 UTC) #3
a.giammarchi
On 2018/06/21 09:54:21, Vasily Kuznetsov wrote: > On 2018/06/20 13:37:15, a.giammarchi wrote: > > P.S. ...
June 21, 2018, 10:44 a.m. (2018-06-21 10:44:50 UTC) #4
Vasily Kuznetsov
LGTM
June 21, 2018, 12:40 p.m. (2018-06-21 12:40:40 UTC) #5
a.giammarchi
On 2018/06/21 12:40:40, Vasily Kuznetsov wrote: > LGTM Thanks. How do we proceed now? Not ...
June 21, 2018, 1:05 p.m. (2018-06-21 13:05:49 UTC) #6
Vasily Kuznetsov
On 2018/06/21 13:05:49, a.giammarchi wrote: > On 2018/06/21 12:40:40, Vasily Kuznetsov wrote: > > LGTM ...
June 21, 2018, 3:05 p.m. (2018-06-21 15:05:38 UTC) #7
Thomas Greiner
No problem. LGTM
June 21, 2018, 3:21 p.m. (2018-06-21 15:21:24 UTC) #8
Vasily Kuznetsov
On 2018/06/21 15:21:24, Thomas Greiner wrote: > No problem. > > LGTM Thank you, Thomas. ...
June 21, 2018, 3:54 p.m. (2018-06-21 15:54:12 UTC) #9
a.giammarchi
On 2018/06/21 15:54:12, Vasily Kuznetsov wrote: > On 2018/06/21 15:21:24, Thomas Greiner wrote: > > ...
June 21, 2018, 9:02 p.m. (2018-06-21 21:02:53 UTC) #10
Vasily Kuznetsov
On 2018/06/21 21:02:53, a.giammarchi wrote: > On 2018/06/21 15:54:12, Vasily Kuznetsov wrote: > > On ...
June 22, 2018, 1:58 p.m. (2018-06-22 13:58:17 UTC) #11
a.giammarchi
June 22, 2018, 2:05 p.m. (2018-06-22 14:05:31 UTC) #12
On 2018/06/22 13:58:17, Vasily Kuznetsov wrote:
> On 2018/06/21 21:02:53, a.giammarchi wrote:
> > On 2018/06/21 15:54:12, Vasily Kuznetsov wrote:
> > > On 2018/06/21 15:21:24, Thomas Greiner wrote:
> > > > No problem.
> > > > 
> > > > LGTM
> > > 
> > > Thank you, Thomas.
> > > 
> > > Andrea, I can push the patch directly from this review. What email address
> > > should I use as committer name? Is "Andrea Giammarchi
> > <mailto:andrea@adblockplus.org>"
> > > correct?
> > 
> > that one or mailto:a.giammarchi@eyeo.com would do (the one I think I use the
> most).
> > 
> > Thanks!
> 
> I pushed this, using mailto:a.giammarchi@eyeo.com address.

Thank you !!!

Powered by Google App Engine
This is Rietveld