Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29837555: Issue 6538, 6781 - Minimize access to ElemHideBase's selector property (Closed)

Created:
July 24, 2018, 1:46 p.m. by Manish Jethani
Modified:
July 24, 2018, 8 p.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

We need to minimize access to this property now that it's a getter and calls String.replace internally.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M lib/elemHide.js View 5 chunks +21 lines, -14 lines 0 comments Download
M lib/elemHideEmulation.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Manish Jethani
July 24, 2018, 1:46 p.m. (2018-07-24 13:46:10 UTC) #1
Manish Jethani
Patch Set 1
July 24, 2018, 1:47 p.m. (2018-07-24 13:47:19 UTC) #2
hub
July 24, 2018, 7:54 p.m. (2018-07-24 19:54:12 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld