Issue 29855590: Noissue - Avoid :-abp-properties() legacy syntax parsing for most filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29855590: Noissue - Avoid :-abp-properties() legacy syntax parsing for most filters (Closed)

Created:
Aug. 14, 2018, 5:22 p.m. by Manish Jethani

Modified:
Aug. 15, 2018, 8:17 a.m.

Reviewers:
sergei, hub, Jon Sonesen

CC:
kzar

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

This speeds up the loading of the initial subscriptions by ~30% for me. It works because most of the element hiding filters (e.g. "example.com##.foo") don't contain the string "[-", but we're still running the regular expression for the :-abp-properties() legacy syntax for those filters. By checking for "[-" we run the regular expression for only ~20 filters. We should entirely remove support for the old syntax but that's a separate issue.

Patch Set 1 #

Created: Aug. 14, 2018, 5:22 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/filterClasses.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sergei

LGTM, BTW, according to http://hub.eyeo.com/issues/7571 it is worth to check all subscriptions, which are listed ...

Aug. 15, 2018, 8:14 a.m. (2018-08-15 08:14:04 UTC) #3

Manish Jethani

Aug. 15, 2018, 8:17 a.m. (2018-08-15 08:17:44 UTC) #4

On 2018/08/15 08:14:04, sergei wrote:
> LGTM,

Thanks!

> BTW, according to http://hub.eyeo.com/issues/7571 it is worth to check all
> subscriptions, which are listed in our xml file, and if there is no any such
> filter then just drop the legacy syntax.

This would be a breaking change so let me file a Trac issue for this.

Expand All Messages | Collapse All Messages