Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29868577: Issue 6891 - Rename FilterNotifier to filterNotifier (Closed)

Created:
Aug. 29, 2018, 2 p.m. by Manish Jethani
Modified:
Aug. 29, 2018, 5:29 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

See the issue description. Class names should start with upper case, class instance names should start with lower case.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -73 lines) Patch
M lib/elemHide.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/elemHideExceptions.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/filterClasses.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/filterListener.js View 2 chunks +20 lines, -20 lines 0 comments Download
M lib/filterNotifier.js View 1 chunk +6 lines, -4 lines 0 comments Download
M lib/filterStorage.js View 10 chunks +11 lines, -11 lines 0 comments Download
M lib/subscriptionClasses.js View 9 chunks +9 lines, -9 lines 0 comments Download
M lib/synchronizer.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/filterNotifier.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/filterStorage.js View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Aug. 29, 2018, 2 p.m. (2018-08-29 14:00:41 UTC) #1
Manish Jethani
Patch Set 1
Aug. 29, 2018, 2:01 p.m. (2018-08-29 14:01:32 UTC) #2
hub
Aug. 29, 2018, 4:21 p.m. (2018-08-29 16:21:35 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld