Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/exceptions/xmlhttprequest.tmpl

Issue 29871625: Noissue - Fixed "$xmlhttprequest Exception" test case (Closed)
Patch Set: Created Sept. 1, 2018, 7:25 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/exceptions/xmlhttprequest.tmpl
===================================================================
--- a/pages/exceptions/xmlhttprequest.tmpl
+++ b/pages/exceptions/xmlhttprequest.tmpl
@@ -18,7 +18,7 @@
var req = new XMLHttpRequest();
req.addEventListener("error", failed);
req.addEventListener("abort", aborted);
- req.open("GET", "http://testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/text.txt", true);
+ req.open("GET", "https://testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/text.txt", true);
req.onload = function(e) {
if (this.status == 200) {
pagelog(this.responseText);
@@ -41,13 +41,17 @@
<p>The XMLHTTPRequest should not be blocked. The Image should be blocked.</p>
<div class="testcase-container">
<div class="testcase-row">
- <h3>XMLHTTPRequest</h3><div id="testcase-output"></div>
+ <h3>XMLHTTPRequest</h3>
+ <div id="testcase-output"></div>
+ <div id="testcase-output-expected">
+ Text loaded via XMLHTTPRequest
+ </div>
</div>
<div class="testcase-row">
- <h3>Image</h3><img class="testcase-image" src="/testcasefiles/xmlhttprequestexception/image.jpg"/>
+ <h3>Image</h3><img class="blocked" src="/testcasefiles/xmlhttprequestexception/image.jpg"/>
</div>
</div>
<h3>Filters</h3>
<pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>
Sebastian Noack 2018/09/01 19:30:48 There were several issues with this test case: 1.
<pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhttprequest</pre>
-</section>
+</section>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld