Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29887560: Issue 6972 - Use Buffer.from in tests (Closed)

Created:
Sept. 21, 2018, 9:08 a.m. by Manish Jethani
Modified:
Sept. 21, 2018, 2:06 p.m.
Reviewers:
hub, Jon Sonesen
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/_common.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Sept. 21, 2018, 9:08 a.m. (2018-09-21 09:08:49 UTC) #1
Manish Jethani
Patch Set 1 See issue description. We're getting a deprecation warning on Node.js v10.10.0.
Sept. 21, 2018, 9:10 a.m. (2018-09-21 09:10:54 UTC) #2
hub
Sept. 21, 2018, 1:07 p.m. (2018-09-21 13:07:40 UTC) #3
it was already deprecated in 7.x (no warning though) which is our minimum. 

LGTM

Powered by Google App Engine
This is Rietveld