Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/runners/chromium_process.js

Issue 29891680: Issue 6986 - Don't use chromium remote interface on Windows (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Donc run headless on Windows Created Sept. 27, 2018, 5 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/runners/chromium_remote_process.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runners/chromium_process.js
===================================================================
--- a/test/runners/chromium_process.js
+++ b/test/runners/chromium_process.js
@@ -28,22 +28,25 @@
// Chromium 63.0.3239.x is 508578
// Chromium 65.0.3325.0 is 530368
// We currently want Chromiun 63, as we still support it and that's the
// loweset version that supports WebDriver.
const CHROMIUM_REVISION = 508578;
function runScript(chromiumPath, script, scriptName, scriptArgs)
{
+ let {platform} = process;
Sebastian Noack 2018/09/28 15:37:00 Nit: This doesn't seem to be worth a temporary var
hub 2018/09/28 15:56:35 Done.
const options = new chrome.Options()
- .headless()
// Disabling sandboxing is needed on some system configurations
// like Debian 9.
.addArguments("--no-sandbox")
.setChromeBinaryPath(chromiumPath);
+ // Headless doesn't seem to work on Windows.
+ if (platform != "win32")
+ options.headless();
const driver = new Builder()
.forBrowser("chrome")
.setChromeOptions(options)
.build();
return executeScript(driver, "Chromium (WebDriver)",
script, scriptName, scriptArgs);
« no previous file with comments | « no previous file | test/runners/chromium_remote_process.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld