Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29892566: Noissue - Use for...of in tabs.onActivated handler (Closed)

Created:
Sept. 26, 2018, 4:40 p.m. by Manish Jethani
Modified:
Sept. 26, 2018, 4:46 p.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Use for...of in tabs.onActivated handler

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ext/background.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Sept. 26, 2018, 4:40 p.m. (2018-09-26 16:40:57 UTC) #1
Sebastian Noack
LGTM
Sept. 26, 2018, 4:42 p.m. (2018-09-26 16:42:14 UTC) #2
Manish Jethani
Sept. 26, 2018, 4:42 p.m. (2018-09-26 16:42:34 UTC) #3
Patch Set 1

I'm looking into performance now. It seems that ~3% of the extension's time is
spent here when a new tab is opened with one of the Alexa Top 50 sites. Also
seems like using a for...of loop here reduces that time significantly.

Powered by Google App Engine
This is Rietveld