.gitlab-ci.yml - Issue 29904564: Issue 6682 - Automated builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .gitlab-ci.yml

Issue 29904564: Issue 6682 - Automated builds (Closed)

Left Patch Set: Created Oct. 8, 2018, 2:46 p.m.

Right Patch Set: Created Oct. 8, 2018, 3:38 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # This file is part of Adblock Plus <https://adblockplus.org/>,	1 # This file is part of Adblock Plus <https://adblockplus.org/>,

2 # Copyright (C) 2006-present eyeo GmbH	2 # Copyright (C) 2006-present eyeo GmbH

3 #	3 #

4 # Adblock Plus is free software: you can redistribute it and/or modify	4 # Adblock Plus is free software: you can redistribute it and/or modify

5 # it under the terms of the GNU General Public License version 3 as	5 # it under the terms of the GNU General Public License version 3 as

6 # published by the Free Software Foundation.	6 # published by the Free Software Foundation.

7 #	7 #

8 # Adblock Plus is distributed in the hope that it will be useful,	8 # Adblock Plus is distributed in the hope that it will be useful,

9 # but WITHOUT ANY WARRANTY; without even the implied warranty of	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 .build:	46 .build:

47 extends: .pull_cache	47 extends: .pull_cache

48 before_script: *dependencies	48 before_script: *dependencies

49 stage: build	49 stage: build

50 only:	50 only:

51 - master	51 - master

52 script:	52 script:

53 - python build.py build -t $PLATFORM	53 - python build.py build -t $PLATFORM

54 artifacts:	54 artifacts:

55 paths:	55 paths:

56 - ./*.xpi	56 - adblockplusfirefox-*.xpi

57 - ./*.zip	57 - adblockpluschrome-*.zip

58 - ./*.appx	58 - adblockplusedge-*.appx
Sebastian Noack 2018/10/08 15:16:55 Perhaps we should make the filename a little more Perhaps we should make the filename a little more specific. e.g. adblockpluschrome-.zip. Also from the example in the documentation adding ./ doesn't seem to be necessary, or do I miss something here? tlucas* 2018/10/08 15:39:13 IMHO ideally, we would again read the "basename" a Show quoted text On 2018/10/08 15:16:55, Sebastian Noack wrote: > Perhaps we should make the filename a little more specific. e.g. > adblockpluschrome-*.zip. Also from the example in the documentation adding ./ > doesn't seem to be necessary, or do I miss something here? IMHO ideally, we would again read the "basename" and the extension for $PLATFORM here, to match to correct file - unfortunately, (dynamic) variables are not available in artifact:paths. -> Done, as per your suggestion.
59	59

60 prepare-dependencies:	60 prepare-dependencies:

61 stage: prepare	61 stage: prepare

62 script: *dependencies	62 script: *dependencies

63 cache:	63 cache:

64 key: cache_$CI_COMMIT_SHA	64 key: cache_$CI_COMMIT_SHA

65 paths:	65 paths:

66 - ./	66 - ./

67 policy: push	67 policy: push

68	68

(...skipping 19 matching lines...) Expand all Loading...
88	88

89 build:gecko:	89 build:gecko:

90 extends: .build	90 extends: .build

91 variables:	91 variables:

92 PLATFORM: gecko	92 PLATFORM: gecko

93	93

94 build:edge:	94 build:edge:

95 extends: .build	95 extends: .build

96 variables:	96 variables:

97 PLATFORM: edge	97 PLATFORM: edge

	98 # see https://issues.adblockplus.org/ticket/7024

98 allow_failure: true	99 allow_failure: true
Sebastian Noack 2018/10/08 15:16:55 Can we add a comment referring to the issue here? Can we add a comment referring to the issue here? tlucas 2018/10/08 15:39:13 Done. Show quoted text On 2018/10/08 15:16:55, Sebastian Noack wrote: > Can we add a comment referring to the issue here? Done.
LEFT	RIGHT