Issue 6682 - Automated builds

Issue 6682: Automated builds

Actual commit messages:

Issue 6682 - Create builds through CI
Issue 6682 - Update buildtools to 59a519c38766 / 9342139

Pipeline for master, with builds:
https://gitlab.com/triluc/adblockpluschrome/pipelines/32309636

Pipeline for a random branch, without builds:
https://gitlab.com/triluc/adblockpluschrome/pipelines/32309646

[tlucas, 2018-10-08 14:51:32]

Patch Set 1:
 * Update buildtools dependency
 * Add 'build:{gecko|chrome|edge}'-jobs to CI

[Sebastian Noack, 2018-10-08 15:16:55]

https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml
File .gitlab-ci.yml (right):

https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml#newc...
.gitlab-ci.yml:58: - ./*.appx
Perhaps we should make the filename a little more specific. e.g.
adblockpluschrome-*.zip. Also from the example in the documentation adding ./
doesn't seem to be necessary, or do I miss something here?

https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml#newc...
.gitlab-ci.yml:98: allow_failure: true
Can we add a comment referring to the issue here?

[tlucas, 2018-10-08 15:39:13]

Patch Set 2:
 * Address Sebastian comments.

New pipelines:

https://gitlab.com/triluc/adblockpluschrome/pipelines/32316067 (master)
https://gitlab.com/triluc/adblockpluschrome/pipelines/32316008 (arbitrary)

https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml
File .gitlab-ci.yml (right):

https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml#newc...
.gitlab-ci.yml:58: - ./*.appx
On 2018/10/08 15:16:55, Sebastian Noack wrote:
> Perhaps we should make the filename a little more specific. e.g.
> adblockpluschrome-*.zip. Also from the example in the documentation adding ./
> doesn't seem to be necessary, or do I miss something here?

IMHO ideally, we would again read the "basename" and the extension for $PLATFORM
here, to match to correct file - unfortunately, (dynamic) variables are not
available in artifact:paths.

-> Done, as per your suggestion.

https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml#newc...
.gitlab-ci.yml:98: allow_failure: true
On 2018/10/08 15:16:55, Sebastian Noack wrote:
> Can we add a comment referring to the issue here?

Done.

[Sebastian Noack, 2018-10-08 15:43:06]

LGTM

[wspee, 2018-10-08 15:48:47]

LGTM