Issue 7145 - Change manifest name for release builds

Issue 7145 - Change manifest name for release builds

[Sebastian Noack, 2018-12-27 21:48:02]

Please adapt line 167 in packegerEdge.py. Otherwise, this change will break the
builds for Microsoft Edge again. For more details read the comment in the source
code above that location.

[Sebastian Noack, 2018-12-28 04:49:24]

On 2018/12/27 21:48:02, Sebastian Noack wrote:
> Please adapt line 167 in packegerEdge.py. Otherwise, this change will break
the
> builds for Microsoft Edge again. For more details read the comment in the
source
> code above that location.

Actually, thinking one step ahead we might want to not change the name on
Microsoft Edge at all. We cannot translate it (without going to quite some
length). So we might want to add any language-specific phrases in there.

[wspee, 2018-12-28 15:00:24]

On 2018/12/28 04:49:24, Sebastian Noack wrote:
> On 2018/12/27 21:48:02, Sebastian Noack wrote:
> > Please adapt line 167 in packegerEdge.py. Otherwise, this change will break
> the
> > builds for Microsoft Edge again. For more details read the comment in the
> source
> > code above that location.
> 
> Actually, thinking one step ahead we might want to not change the name on
> Microsoft Edge at all. We cannot translate it (without going to quite some
> length). So we might want to add any language-specific phrases in there.

For SEO purposes (i.e. rank higher for the term "ad blocker") it makes sense to
change the name for edge as well even if we can never translate it. I have
therefore updated the regexp in `packagerEdge.py` instead.

[Sebastian Noack, 2018-12-28 21:17:46]

On 2018/12/28 15:00:24, wspee wrote:
> For SEO purposes (i.e. rank higher for the term "ad blocker") it makes sense
to
> change the name for edge as well even if we can never translate it. I have
> therefore updated the regexp in `packagerEdge.py` instead.

Fair enough.

Mind updating the tests? They are failing now, after these changes.

[wspee, 2018-12-29 17:05:11]

On 2018/12/28 21:17:46, Sebastian Noack wrote:
> On 2018/12/28 15:00:24, wspee wrote:
> > For SEO purposes (i.e. rank higher for the term "ad blocker") it makes sense
> to
> > change the name for edge as well even if we can never translate it. I have
> > therefore updated the regexp in `packagerEdge.py` instead.
> 
> Fair enough.
> 
> Mind updating the tests? They are failing now, after these changes.

Ah sorry, the bane of the casual contributor. I have updated the test cases
accordingly.

[Sebastian Noack, 2018-12-29 17:17:40]

LGTM