Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29977571: Issue 7201 - Add links to CMS documentation (Closed)

Created:
Jan. 10, 2019, 12:01 a.m. by rhowell
Modified:
Jan. 17, 2019, 8:48 p.m.
Reviewers:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/cms/
Visibility:
Public.

Description

Issue 7201 - Add links to CMS documentation

Patch Set 1 #

Patch Set 2 : Address comments on PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M docs/api/filters.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/api/functions.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/api/variables.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/filters.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/globals.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/includes.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/locales.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/pages.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/settings.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/static.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/content/templates.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/usage/generate-static-files.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/usage/standalone-test-server.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/usage/syncing-translations.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/usage/test-server.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M docs/usage/xml-sync.md View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
rhowell
Jan. 10, 2019, 12:01 a.m. (2019-01-10 00:01:23 UTC) #1
Vasily Kuznetsov
Hi Rosie, Looks good. Two questions: 1. Have you thought about putting the links at ...
Jan. 10, 2019, 4:24 p.m. (2019-01-10 16:24:01 UTC) #2
rhowell
On 2019/01/10 16:24:01, Vasily Kuznetsov wrote: > 1. Have you thought about putting the links ...
Jan. 10, 2019, 8:21 p.m. (2019-01-10 20:21:27 UTC) #3
Vasily Kuznetsov
On 2019/01/10 20:21:27, rhowell wrote: > On 2019/01/10 16:24:01, Vasily Kuznetsov wrote: > > > ...
Jan. 14, 2019, 2:12 p.m. (2019-01-14 14:12:15 UTC) #4
rhowell
Hi Vasily, 5 dashes sounds good. Also, one other question: I noticed that docs/usage/xml-sync.md wasn't ...
Jan. 14, 2019, 3:34 p.m. (2019-01-14 15:34:10 UTC) #5
Vasily Kuznetsov
On 2019/01/14 15:34:10, rhowell wrote: > Hi Vasily, > > 5 dashes sounds good. Also, ...
Jan. 14, 2019, 4:15 p.m. (2019-01-14 16:15:46 UTC) #6
rhowell
On 2019/01/14 16:15:46, Vasily Kuznetsov wrote: > On 2019/01/14 15:34:10, rhowell wrote: > > Hi ...
Jan. 17, 2019, 7:16 a.m. (2019-01-17 07:16:31 UTC) #7
Vasily Kuznetsov
Jan. 17, 2019, 10:25 a.m. (2019-01-17 10:25:42 UTC) #8
> Ah, makes sense, thanks Vasily. Anything else, or should I push this?

You can push it. LGTM

Powered by Google App Engine
This is Rietveld