Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29978576: Issue 7208 - Drop superfluous wildcards before processing pattern (Closed)

Created:
Jan. 10, 2019, 10:43 p.m. by Manish Jethani
Modified:
Jan. 15, 2019, 2:19 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix spelling #

Patch Set 3 : Move rewrite property to RegExpFilter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M lib/filterClasses.js View 1 2 5 chunks +25 lines, -17 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
Jan. 10, 2019, 10:43 p.m. (2019-01-10 22:43:17 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29978576/diff/29978577/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29978576/diff/29978577/lib/filterClasses.js#newcode697 lib/filterClasses.js:697: function RegExpFilter(text, regexpSource, contentType, matchCase, domains, ...
Jan. 10, 2019, 10:52 p.m. (2019-01-10 22:52:22 UTC) #2
Manish Jethani
Patch Set 2: Fix spelling Patch Set 3: Move rewrite property to RegExpFilter I've moved ...
Jan. 10, 2019, 11:04 p.m. (2019-01-10 23:04:45 UTC) #3
hub
Jan. 11, 2019, 3:26 p.m. (2019-01-11 15:26:23 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld