Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29996555: Noissue - Lower-case URL in advance for location-only filters (Closed)

Created:
Feb. 2, 2019, 5:33 a.m. by Manish Jethani
Modified:
Feb. 4, 2019, 11:08 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

The matchesLocation function is now a hot spot. This change cuts down the amount of time spent in the function by about two-thirds.

Patch Set 1 #

Patch Set 2 : Add JSDoc access tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M lib/filterClasses.js View 1 1 chunk +5 lines, -2 lines 0 comments Download
M lib/matcher.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
Manish Jethani
Feb. 2, 2019, 5:33 a.m. (2019-02-02 05:33:16 UTC) #1
Manish Jethani
Patch Set 2: Add JSDoc access tag This should be package-level access, i.e. external clients ...
Feb. 2, 2019, 10:55 a.m. (2019-02-02 10:55:26 UTC) #2
Manish Jethani
This is a relatively simple change so hoping to get this into Adblock Plus 3.5.
Feb. 4, 2019, 3:07 p.m. (2019-02-04 15:07:01 UTC) #3
hub
Feb. 4, 2019, 9:14 p.m. (2019-02-04 21:14:18 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld