Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/filterStorage_readwrite.js

Issue 30013625: Issue 7094 - Link filters with subscriptions in INI parser (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Minor formatting change Created Feb. 22, 2019, 2:55 p.m.
Right Patch Set: Use template string Created Feb. 22, 2019, 3:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/iniParser.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 194
195 for (let filterSubscription of Filter.fromText(text).subscriptions()) 195 for (let filterSubscription of Filter.fromText(text).subscriptions())
196 { 196 {
197 if (filterSubscription == subscription) 197 if (filterSubscription == subscription)
198 { 198 {
199 found = true; 199 found = true;
200 break; 200 break;
201 } 201 }
202 } 202 }
203 203
204 test.ok(found, "Filter " + JSON.stringify(text) + " " + 204 test.ok(found, `Filter ${text} should be linked to subscription ${subscr iption.url}`);
205 "should be linked to its subscription " +
206 subscription.url);
hub 2019/02/22 15:28:04 I think using a template string here would be clea
Manish Jethani 2019/02/22 15:48:38 Done.
207 } 205 }
208 } 206 }
209 } 207 }
210 catch (error) 208 catch (error)
211 { 209 {
212 unexpectedError.call(test, error); 210 unexpectedError.call(test, error);
213 } 211 }
214 212
215 test.done(); 213 test.done();
216 }; 214 };
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 314
317 test.equal([...filterStorage.subscriptions()][0].filterCount, 1, "Filter cou nt after reloading"); 315 test.equal([...filterStorage.subscriptions()][0].filterCount, 1, "Filter cou nt after reloading");
318 } 316 }
319 catch (error) 317 catch (error)
320 { 318 {
321 unexpectedError.call(test, error); 319 unexpectedError.call(test, error);
322 } 320 }
323 321
324 test.done(); 322 test.done();
325 }; 323 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld