Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 30013625: Issue 7094 - Link filters with subscriptions in INI parser (Closed)

Created:
Feb. 22, 2019, 1:28 a.m. by Manish Jethani
Modified:
Feb. 22, 2019, 5:53 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Minor formatting change #

Total comments: 2

Patch Set 4 : Use template string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M lib/iniParser.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/filterStorage_readwrite.js View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
Feb. 22, 2019, 1:28 a.m. (2019-02-22 01:28:57 UTC) #1
Manish Jethani
Patch Set 1 This is a fix for the regression introduced in changeset b30aa01e56ca. We ...
Feb. 22, 2019, 1:31 a.m. (2019-02-22 01:31:33 UTC) #2
hub
LGTM but there should have been tests to catch this IMHO
Feb. 22, 2019, 2:24 p.m. (2019-02-22 14:24:43 UTC) #3
Manish Jethani
On 2019/02/22 14:24:43, hub wrote: > LGTM > > but there should have been tests ...
Feb. 22, 2019, 2:50 p.m. (2019-02-22 14:50:03 UTC) #4
Manish Jethani
Patch Set 3
Feb. 22, 2019, 2:58 p.m. (2019-02-22 14:58:23 UTC) #5
hub
https://codereview.adblockplus.org/30013625/diff/30014558/test/filterStorage_readwrite.js File test/filterStorage_readwrite.js (right): https://codereview.adblockplus.org/30013625/diff/30014558/test/filterStorage_readwrite.js#newcode206 test/filterStorage_readwrite.js:206: subscription.url); I think using a template string here would ...
Feb. 22, 2019, 3:28 p.m. (2019-02-22 15:28:04 UTC) #6
Manish Jethani
Patch Set 4 https://codereview.adblockplus.org/30013625/diff/30014558/test/filterStorage_readwrite.js File test/filterStorage_readwrite.js (right): https://codereview.adblockplus.org/30013625/diff/30014558/test/filterStorage_readwrite.js#newcode206 test/filterStorage_readwrite.js:206: subscription.url); On 2019/02/22 15:28:04, hub wrote: ...
Feb. 22, 2019, 3:48 p.m. (2019-02-22 15:48:38 UTC) #7
hub
Feb. 22, 2019, 4:33 p.m. (2019-02-22 16:33:09 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld