Initial configuration for issues.adblockplus.org

With this, we'll have a very basic Roundup instance running on issues.adblockplus.org. Some long term issues remain:

1. We should configure postfix to use an SMTP relay
2. We should use the roundup WSGI bridge instead of the standalone server
3. We should make it possible to create private issues (Roundup's permission system can do that)

However, I think this is something we can get started with.

[christian, 2014-01-14 10:01:23]

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/templates/config.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:140: name = Roundup issue tracker
We should change the name in something like "AdblockPlus Issue tracker"

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:195: debug = yes
Is "debug = yes" set only for the test phase? If we use roundup in productive it
will be better if we set it to no. So we get information that something is
wrong, rather expose parts of our infrastructure to the users, that we maybe
don't want to expose (depends on how verbose this debug is)

[christian, 2014-01-14 10:57:47]

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/Vagr...
File Vagrantfile (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/Vagr...
Vagrantfile:53: define_standard_vm config, 'issues1', '10.8.0.130'
I just noticed that stats1 has already the IP address:

define_standard_vm config, 'stats1', '10.8.0.130'

[Wladimir Palant, 2014-01-22 09:05:28]

In addition to the comments below: this server needs to be added to monitoring
as well.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/manifests/init.pp (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:11: include postfix
Why do we need that? It is already included in the base module.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:15: }
Any particular reason why we are using MySQL rather than PostgreSQL? Discourse
uses the latter and I assumed that we preferred it here as well.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:49: $db_path = "${tracker_home}/db"
Nit: move this further down where it is used?

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:54: require => Package['roundup']
Doesn't that require config.ini or at least roundup-server.ini?

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:71: command => "bash
${roundup_initialise_wrapper}",
Why use a script file? "bash -c 'echo y | roundup-admin ...'" should do.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/templates/config.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:38: admin_email = root@localhost
admins@adblockplus.org? Or isn't that the final value?

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:318: host = localhost
Heh, looking at http://issues.roundup-tracker.org/issue2550747 it seems that
RoundUp can indeed only communicate via SMTP.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/templates/roundup-server.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/roundup-server.ini.erb:2: #
/usr/share/doc/roundup/admin_guide.txt.gz for details
Change that into http://roundup.sourceforge.net/docs/admin_guide.html? :)

[Felix Dahlke, 2014-01-22 13:53:58]

Fixed the issues I agreed on and replied to the other comments.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/Vagr...
File Vagrantfile (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/Vagr...
Vagrantfile:53: define_standard_vm config, 'issues1', '10.8.0.130'
On 2014/01/14 10:57:47, christian wrote:
> I just noticed that stats1 has already the IP address:
> 
> define_standard_vm config, 'stats1', '10.8.0.130'

Yup, another server has been added in the mean time, I'll rebase respectively.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/manifests/init.pp (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:11: include postfix
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Why do we need that? It is already included in the base module.

Done.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:15: }
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Any particular reason why we are using MySQL rather than PostgreSQL? Discourse
> uses the latter and I assumed that we preferred it here as well.

Discourse doesn't support MySQL, that's why I went for PostgreSQL there. Other
than that, we seem to use MySQL/MariaDB everywhere, so I went for that. Worked
with both and don't really have a strong opinion. Might also be a bit less
confusing for the PHPBB migration.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:49: $db_path = "${tracker_home}/db"
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Nit: move this further down where it is used?

Done.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:54: require => Package['roundup']
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Doesn't that require config.ini or at least roundup-server.ini?

Yes, both apparently. Added a notify to those.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/manifests/init.pp:71: command => "bash
${roundup_initialise_wrapper}",
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Why use a script file? "bash -c 'echo y | roundup-admin ...'" should do.

Well that's embarrassing, didn't think of -c. Done.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/templates/config.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:38: admin_email = root@localhost
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> admins@adblockplus.org? Or isn't that the final value?

Done.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:140: name = Roundup issue tracker
On 2014/01/14 10:01:24, christian wrote:
> We should change the name in something like "AdblockPlus Issue tracker"

Done.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:195: debug = yes
On 2014/01/14 10:01:24, christian wrote:
> Is "debug = yes" set only for the test phase? If we use roundup in productive
it
> will be better if we set it to no. So we get information that something is
> wrong, rather expose parts of our infrastructure to the users, that we maybe
> don't want to expose (depends on how verbose this debug is)

Done.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:318: host = localhost
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Heh, looking at http://issues.roundup-tracker.org/issue2550747 it seems that
> RoundUp can indeed only communicate via SMTP.

Think that's a problem for us? Postfix is already running locally and we need it
to use a smart host anyway.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/templates/roundup-server.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/roundup-server.ini.erb:2: #
/usr/share/doc/roundup/admin_guide.txt.gz for details
On 2014/01/22 09:05:29, Wladimir Palant wrote:
> Change that into http://roundup.sourceforge.net/docs/admin_guide.html? :)

Done.

[Wladimir Palant, 2014-01-22 14:43:18]

LGTM with the two nits below fixed.

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
File modules/roundup/templates/config.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5724160613416960/modu...
modules/roundup/templates/config.ini.erb:318: host = localhost
On 2014/01/22 13:53:58, Felix H. Dahlke wrote:
> Think that's a problem for us? Postfix is already running locally and we need
it
> to use a smart host anyway.

No, it's merely annoying that we have tweak Postfix config for this.

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/mani...
File manifests/vagrant.pp (right):

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/mani...
manifests/vagrant.pp:45: {host => 'issues.adblockplus.org', ip => '10.8.0.131'},
Add the host to http-servers group as well?

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/modu...
File modules/roundup/templates/roundup-server.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/modu...
modules/roundup/templates/roundup-server.ini.erb:2: #
http://roundup.sourceforge.net/docs/admin_guide.html? for details
Nit: the question mark wasn't part of the URL.

[Felix Dahlke, 2014-01-22 14:50:53]

Add to monitoring, rename to issues1 consistently, remove trailing ?

[Felix Dahlke, 2014-01-22 14:51:35]

Fixed the new issues. Also realised that I'm sometimes calling the server
"issues", while it should always be called "issues1".

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/mani...
File manifests/vagrant.pp (right):

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/mani...
manifests/vagrant.pp:45: {host => 'issues.adblockplus.org', ip => '10.8.0.131'},
On 2014/01/22 14:43:19, Wladimir Palant wrote:
> Add the host to http-servers group as well?

Done. Forgot to add it to monitoring altogether actually.

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/modu...
File modules/roundup/templates/roundup-server.ini.erb (right):

http://codereview.adblockplus.org/4553114493386752/diff/5693417237512192/modu...
modules/roundup/templates/roundup-server.ini.erb:2: #
http://roundup.sourceforge.net/docs/admin_guide.html? for details
On 2014/01/22 14:43:19, Wladimir Palant wrote:
> Nit: the question mark wasn't part of the URL.

Done.

[christian, 2014-01-22 14:56:08]

LGTM

[Wladimir Palant, 2014-01-22 15:00:35]

LGTM